distro: add erofs options into iso by avitova · Pull Request #2196 · osbuild/images

avitova · 2026-02-12T15:08:20Z

This commit adds the erofs extended options into the iso configuration.

supakeen

I've added two concrete comments about the code. With those addressed this would be a good first commit.

However, the commit message is very descriptive. I can see the diff; it's often better to use the commit message to contain the why.

With this first commit more needs to be done to actually use these values in the pipeline generators.

Since the values are now available in the ISOCustomizations struct a good next commit would be to plumb them through. This would involve.

In pkg/manifest/anaconda_installer_iso_tree.go you will find a NewErofsStage function where you should use these options.

Let's keep that as separate commits so the first commit contains the 'its now possible to set erofs options in the yaml', and the second commit is 'the erofs options from the yaml now get used'.

pkg/distro/generic/images.go

pkg/distro/defs/loader_test.go

supakeen

Nice, the first bits now look a lot better (and have a test!). Let's start adjusting the stuff that uses this; that's mostly pkg/manifest/anaconda_installer_iso_tree.go in the NewErofsStage function.

We should be using the ISOCustomizations that are now set based on the YAML there for the erofsOptions; since you embedded the stage options directly in the YAML this should quick to do.

Note that once you do this your manifests will likely change as you now must have the same values in the YAML as those that were previously set in the Go code, but you can tinker with that.

It should be possible to plumb this in without any manifests changing if the same options are present in the YAML for the image types affected 🙂.

pkg/distro/defs/loader_test.go

pkg/distro/generic/images.go

data/distrodefs/fedora/imagetypes.yaml

supakeen

Awesome, this now functionally does what it needs to do.

Let's clean up the commit history a bit so everything is grouped nicer and it's a bit easier to review when going commit-by-commit.

First, rebase on the latest main. Then let's squash:

distro: add erofs options into iso
test: add loader test for erofs config
distro: set rootfs compression default value back

Together into a single commit. It makes sense to have the test be part of the introduction of the code, and the rootfs default value is a review fixup.

We'll also squash the following commits together:

pkg/manifest: add configurable erofs options into iso tree
distro: add configurable erofs into anaconda inst

They both do the same thing but in different files.

I also have some code remarks but I'll add them after you've done the above squashing so it's a easier to integrate them.

supakeen

I'll request changes, we had a little chat and the current idiom of only overwriting what is set in the YAML is tedious. Let's assume that the YAML contains correct stage options.

That means: let's change the implementation to take whatever-was-in-the-YAML for the erofsOptions and only overwrite filename and excluded-paths.

We might iterate on that and move those into the YAML as well; but maybe not in this PR :)

data/distrodefs/fedora/imagetypes.yaml

pkg/manifest/anaconda_installer_iso_tree.go

pkg/manifest/iso_tree.go

pkg/manifest/anaconda_installer_iso_tree.go

pkg/manifest/iso_tree.go

avitova · 2026-02-17T13:28:01Z

pkg/manifest/anaconda_installer_iso_tree_test.go

+		manifest.ISOCustomizations{
+			ErofsOptions: &osbuild.ErofsStageOptions{},
+		},


This is the only difference we needed to make, and ErofsOptions in anacondaPipeline is private, so we cannot just override newTestAnacondaISOTree, thus the redundancy.

Can you make it an argument on newTestAnacondaISOTree()?
Otherwise, you can add a function in pkg/manifest/export_test.go that modifies the pipeline for the test.

avitova

Okay, now I understand. I had to change tests because of the 'fail early' Erofs new behaviour.

achilleas-k

Some minor comments. Nothing to block on. LGTM!

achilleas-k · 2026-02-17T14:23:59Z

pkg/manifest/iso.go

-	RootfsType ISORootfsType
-	BootType   ISOBootType
+	RootfsType   ISORootfsType
+	ErofsOptions *osbuild.ErofsStageOptions


Not really a fan of piping stage options from the top-level yaml all the way down to the manifest. I know we do this in a few places, in fact I think I might have been the most recent person to do the same. I just wanted to point out that we should be better about separating these things when we can.

Or maybe we should embrace it and go all in, make the ImageConfig a collection of stage options ... 🤔

We should definitely have a discussion about this at some point and either forbid it or not. Probably once we start stabilizing the YAML.

achilleas-k · 2026-02-17T14:29:44Z

pkg/manifest/anaconda_installer_iso_tree_test.go

+		manifest.ISOCustomizations{
+			ErofsOptions: &osbuild.ErofsStageOptions{},
+		},


Can you make it an argument on newTestAnacondaISOTree()?
Otherwise, you can add a function in pkg/manifest/export_test.go that modifies the pipeline for the test.

This commit enables configuration of erofs extended options, compression and clustersize fields.

supakeen · 2026-02-17T16:45:35Z

Rebased on main where the disk size increase has landed. Let's see if it passes.

supakeen · 2026-02-17T19:06:54Z

I've been rude and changed the last commit here to apply the change only to the network-installer, and to switch the compression algorithm to lmza,level=6 and cluster size to 1048576 which is the same as used for other Fedora artifacts that kiwi produces.

Other installers can instead be done as separate follow ups (I'll create PRs for them after this enablement PR lands).

This feels a bit more safe since we were changing some officially produced artifacts which might be a bit too gung-ho, especially so close to a Fedora release.

bcl · 2026-02-18T00:51:47Z

pkg/manifest/anaconda_installer_iso_tree.go

 	}

+	if p.RootfsType != ErofsRootfs || p.anacondaPipeline.ISOCustomizations.ErofsOptions == nil {
+		return nil, fmt.Errorf("Rootfs not set to Erofs or options set to nil for %s pipeline, can not create erofs stage", p.name)


Erofs should be lower case since that's the value that is used in the yaml.

bcl · 2026-02-18T01:01:07Z

data/distrodefs/fedora/imagetypes.yaml

        - ["/usr/share/licenses/fedora-release-common/LICENSE", "/LICENSE"]
      install_weak_deps: false
-    iso_config: *default_iso_config
+    iso_config:


Typically in Fedora we don't make big changes like this to older releases so we may need to limit this to F44 and later. @achilleas-k what do you think?

I think we tend to only do that for deliverables that are actually part of composes in the case of Fedora, the network installer isn't (yet).

Yeah as long as it's not an official image, it's fine to change I think

tag v0.243.0 Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com> Changes with 0.243.0 ---------------- - Move bootc pxe initrd creation into the Containerfile (osbuild/images#2202) - Author: Brian C. Lane, Reviewers: Achilleas Koutsou, Simon de Vlieger - distro: add erofs options into iso (osbuild/images#2196) - Author: Anna Vítová, Reviewers: Simon de Vlieger - fedora: atomic installer default config and erofs (HMS-10220) (osbuild/images#2209) - Author: Simon de Vlieger, Reviewers: Brian C. Lane, Lukáš Zapletal - many: copy ErofsOptions in manifest (osbuild/images#2212) - Author: Lukáš Zapletal, Reviewers: Simon de Vlieger, Tomáš Hozza - schutzbot: bump terraform hash (osbuild/images#2205) - Author: Simon de Vlieger, Reviewers: Anna Vítová, Lukáš Zapletal — Somewhere on the Internet, 2026-02-19 ---

tag v0.241.0 Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com> Changes with 0.241.0 ---------------- - Move bootc distro and image type code into generic distro (osbuild/images#2172) - Author: Achilleas Koutsou, Reviewers: Nobody - Use functions from Go 1.24 stdlib (osbuild/images#2194) - Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou, Simon de Vlieger - distro: introduce ostree default URL (HMS-10152) (osbuild/images#2186) - Author: Simon de Vlieger, Reviewers: Lukáš Zapletal, Tomáš Hozza - distro: move ostree default reference to image type (HMS-10151) (osbuild/images#2184) - Author: Simon de Vlieger, Reviewers: Lukáš Zapletal, Tomáš Hozza — Somewhere on the Internet, 2026-02-16 --- tag v0.242.0 Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com> Changes with 0.242.0 ---------------- - Cleanup remotefile resolver and delete internal/worker (osbuild/images#2178) - Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou, Tomáš Hozza - Enable BSI OpenSCAP profile for RHEL 10.2 (HMS-9407) (osbuild/images#2199) - Author: Gianluca Zuccarelli, Reviewers: Achilleas Koutsou, Tomáš Hozza - New image type for RHEL 9 and 10: ec2-cvm [HMS-10096] (osbuild/images#2177) - Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Tomáš Hozza - Update osbuild dependency commit ID (osbuild/images#2198) - Author: SchutzBot, Reviewers: Achilleas Koutsou, Tomáš Hozza - check-host-config: convert tests to tabular format (osbuild/images#2164) - Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou, Tomáš Hozza - data/repositories: update f45 keys (osbuild/images#2181) - Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Lukáš Zapletal - distro: set ostree ref only on ostree types in test distro (osbuild/images#2201) - Author: Achilleas Koutsou, Reviewers: Brian C. Lane, Simon de Vlieger - fedora: atomic desktops installers and disk images (HMS-10174, HMS-10175) (osbuild/images#2188) - Author: Simon de Vlieger, Reviewers: Lukáš Zapletal, Tomáš Hozza - pkg/cloud/awscloud: allow specifying AWS credentials profile (osbuild/images#2157) - Author: Jakub Kadlčík, Reviewers: Lukáš Zapletal, Simon de Vlieger - rhel/centos-9: grow `/boot` for minimal-raw (osbuild/images#2200) - Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Lukáš Zapletal, Tomáš Hozza - test/scripts: don't use post-release version bump commits for osbuild (osbuild/images#2195) - Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Simon de Vlieger, Tomáš Hozza — Somewhere on the Internet, 2026-02-17 --- tag v0.243.0 Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com> Changes with 0.243.0 ---------------- - Move bootc pxe initrd creation into the Containerfile (osbuild/images#2202) - Author: Brian C. Lane, Reviewers: Achilleas Koutsou, Simon de Vlieger - distro: add erofs options into iso (osbuild/images#2196) - Author: Anna Vítová, Reviewers: Simon de Vlieger - fedora: atomic installer default config and erofs (HMS-10220) (osbuild/images#2209) - Author: Simon de Vlieger, Reviewers: Brian C. Lane, Lukáš Zapletal - many: copy ErofsOptions in manifest (osbuild/images#2212) - Author: Lukáš Zapletal, Reviewers: Simon de Vlieger, Tomáš Hozza - schutzbot: bump terraform hash (osbuild/images#2205) - Author: Simon de Vlieger, Reviewers: Anna Vítová, Lukáš Zapletal — Somewhere on the Internet, 2026-02-19 ---

tag v0.243.0 Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com> Changes with 0.243.0 ---------------- - Move bootc pxe initrd creation into the Containerfile (osbuild/images#2202) - Author: Brian C. Lane, Reviewers: Achilleas Koutsou, Simon de Vlieger - distro: add erofs options into iso (osbuild/images#2196) - Author: Anna Vítová, Reviewers: Simon de Vlieger - fedora: atomic installer default config and erofs (HMS-10220) (osbuild/images#2209) - Author: Simon de Vlieger, Reviewers: Brian C. Lane, Lukáš Zapletal - many: copy ErofsOptions in manifest (osbuild/images#2212) - Author: Lukáš Zapletal, Reviewers: Simon de Vlieger, Tomáš Hozza - schutzbot: bump terraform hash (osbuild/images#2205) - Author: Simon de Vlieger, Reviewers: Anna Vítová, Lukáš Zapletal — Somewhere on the Internet, 2026-02-19 --- tag v0.244.0 Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com> Changes with 0.244.0 ---------------- - pkg/osbuild/rpm: don't collect GPG keys from repos with CheckGPG=false (osbuild/images#2203) - Author: Tomáš Hozza, Reviewers: Achilleas Koutsou, Lukáš Zapletal — Somewhere on the Internet, 2026-02-19 ---

tag v0.241.0 Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com> Changes with 0.241.0 ---------------- - Move bootc distro and image type code into generic distro (osbuild/images#2172) - Author: Achilleas Koutsou, Reviewers: Nobody - Use functions from Go 1.24 stdlib (osbuild/images#2194) - Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou, Simon de Vlieger - distro: introduce ostree default URL (HMS-10152) (osbuild/images#2186) - Author: Simon de Vlieger, Reviewers: Lukáš Zapletal, Tomáš Hozza - distro: move ostree default reference to image type (HMS-10151) (osbuild/images#2184) - Author: Simon de Vlieger, Reviewers: Lukáš Zapletal, Tomáš Hozza — Somewhere on the Internet, 2026-02-16 --- tag v0.242.0 Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com> Changes with 0.242.0 ---------------- - Cleanup remotefile resolver and delete internal/worker (osbuild/images#2178) - Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou, Tomáš Hozza - Enable BSI OpenSCAP profile for RHEL 10.2 (HMS-9407) (osbuild/images#2199) - Author: Gianluca Zuccarelli, Reviewers: Achilleas Koutsou, Tomáš Hozza - New image type for RHEL 9 and 10: ec2-cvm [HMS-10096] (osbuild/images#2177) - Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Tomáš Hozza - Update osbuild dependency commit ID (osbuild/images#2198) - Author: SchutzBot, Reviewers: Achilleas Koutsou, Tomáš Hozza - check-host-config: convert tests to tabular format (osbuild/images#2164) - Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou, Tomáš Hozza - data/repositories: update f45 keys (osbuild/images#2181) - Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Lukáš Zapletal - distro: set ostree ref only on ostree types in test distro (osbuild/images#2201) - Author: Achilleas Koutsou, Reviewers: Brian C. Lane, Simon de Vlieger - fedora: atomic desktops installers and disk images (HMS-10174, HMS-10175) (osbuild/images#2188) - Author: Simon de Vlieger, Reviewers: Lukáš Zapletal, Tomáš Hozza - pkg/cloud/awscloud: allow specifying AWS credentials profile (osbuild/images#2157) - Author: Jakub Kadlčík, Reviewers: Lukáš Zapletal, Simon de Vlieger - rhel/centos-9: grow `/boot` for minimal-raw (osbuild/images#2200) - Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Lukáš Zapletal, Tomáš Hozza - test/scripts: don't use post-release version bump commits for osbuild (osbuild/images#2195) - Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Simon de Vlieger, Tomáš Hozza — Somewhere on the Internet, 2026-02-17 --- tag v0.243.0 Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com> Changes with 0.243.0 ---------------- - Move bootc pxe initrd creation into the Containerfile (osbuild/images#2202) - Author: Brian C. Lane, Reviewers: Achilleas Koutsou, Simon de Vlieger - distro: add erofs options into iso (osbuild/images#2196) - Author: Anna Vítová, Reviewers: Simon de Vlieger - fedora: atomic installer default config and erofs (HMS-10220) (osbuild/images#2209) - Author: Simon de Vlieger, Reviewers: Brian C. Lane, Lukáš Zapletal - many: copy ErofsOptions in manifest (osbuild/images#2212) - Author: Lukáš Zapletal, Reviewers: Simon de Vlieger, Tomáš Hozza - schutzbot: bump terraform hash (osbuild/images#2205) - Author: Simon de Vlieger, Reviewers: Anna Vítová, Lukáš Zapletal — Somewhere on the Internet, 2026-02-19 --- tag v0.244.0 Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com> Changes with 0.244.0 ---------------- - pkg/osbuild/rpm: don't collect GPG keys from repos with CheckGPG=false (osbuild/images#2203) - Author: Tomáš Hozza, Reviewers: Achilleas Koutsou, Lukáš Zapletal — Somewhere on the Internet, 2026-02-19 ---

Changed TestManifestIntegrationOstreeSmokeErrors to use centos-9. Fedora images now define their own ostree URLs so the option is not required. --- tag v0.241.0 Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com> Changes with 0.241.0 ---------------- - Move bootc distro and image type code into generic distro (osbuild/images#2172) - Author: Achilleas Koutsou, Reviewers: Nobody - Use functions from Go 1.24 stdlib (osbuild/images#2194) - Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou, Simon de Vlieger - distro: introduce ostree default URL (HMS-10152) (osbuild/images#2186) - Author: Simon de Vlieger, Reviewers: Lukáš Zapletal, Tomáš Hozza - distro: move ostree default reference to image type (HMS-10151) (osbuild/images#2184) - Author: Simon de Vlieger, Reviewers: Lukáš Zapletal, Tomáš Hozza — Somewhere on the Internet, 2026-02-16 --- tag v0.242.0 Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com> Changes with 0.242.0 ---------------- - Cleanup remotefile resolver and delete internal/worker (osbuild/images#2178) - Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou, Tomáš Hozza - Enable BSI OpenSCAP profile for RHEL 10.2 (HMS-9407) (osbuild/images#2199) - Author: Gianluca Zuccarelli, Reviewers: Achilleas Koutsou, Tomáš Hozza - New image type for RHEL 9 and 10: ec2-cvm [HMS-10096] (osbuild/images#2177) - Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Tomáš Hozza - Update osbuild dependency commit ID (osbuild/images#2198) - Author: SchutzBot, Reviewers: Achilleas Koutsou, Tomáš Hozza - check-host-config: convert tests to tabular format (osbuild/images#2164) - Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou, Tomáš Hozza - data/repositories: update f45 keys (osbuild/images#2181) - Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Lukáš Zapletal - distro: set ostree ref only on ostree types in test distro (osbuild/images#2201) - Author: Achilleas Koutsou, Reviewers: Brian C. Lane, Simon de Vlieger - fedora: atomic desktops installers and disk images (HMS-10174, HMS-10175) (osbuild/images#2188) - Author: Simon de Vlieger, Reviewers: Lukáš Zapletal, Tomáš Hozza - pkg/cloud/awscloud: allow specifying AWS credentials profile (osbuild/images#2157) - Author: Jakub Kadlčík, Reviewers: Lukáš Zapletal, Simon de Vlieger - rhel/centos-9: grow `/boot` for minimal-raw (osbuild/images#2200) - Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Lukáš Zapletal, Tomáš Hozza - test/scripts: don't use post-release version bump commits for osbuild (osbuild/images#2195) - Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Simon de Vlieger, Tomáš Hozza — Somewhere on the Internet, 2026-02-17 --- tag v0.243.0 Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com> Changes with 0.243.0 ---------------- - Move bootc pxe initrd creation into the Containerfile (osbuild/images#2202) - Author: Brian C. Lane, Reviewers: Achilleas Koutsou, Simon de Vlieger - distro: add erofs options into iso (osbuild/images#2196) - Author: Anna Vítová, Reviewers: Simon de Vlieger - fedora: atomic installer default config and erofs (HMS-10220) (osbuild/images#2209) - Author: Simon de Vlieger, Reviewers: Brian C. Lane, Lukáš Zapletal - many: copy ErofsOptions in manifest (osbuild/images#2212) - Author: Lukáš Zapletal, Reviewers: Simon de Vlieger, Tomáš Hozza - schutzbot: bump terraform hash (osbuild/images#2205) - Author: Simon de Vlieger, Reviewers: Anna Vítová, Lukáš Zapletal — Somewhere on the Internet, 2026-02-19 --- tag v0.244.0 Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com> Changes with 0.244.0 ---------------- - pkg/osbuild/rpm: don't collect GPG keys from repos with CheckGPG=false (osbuild/images#2203) - Author: Tomáš Hozza, Reviewers: Achilleas Koutsou, Lukáš Zapletal — Somewhere on the Internet, 2026-02-19 --- Co-authored-by: Brian C. Lane <bcl@redhat.com>

tag v0.243.0 Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com> Changes with 0.243.0 ---------------- - Move bootc pxe initrd creation into the Containerfile (osbuild/images#2202) - Author: Brian C. Lane, Reviewers: Achilleas Koutsou, Simon de Vlieger - distro: add erofs options into iso (osbuild/images#2196) - Author: Anna Vítová, Reviewers: Simon de Vlieger - fedora: atomic installer default config and erofs (HMS-10220) (osbuild/images#2209) - Author: Simon de Vlieger, Reviewers: Brian C. Lane, Lukáš Zapletal - many: copy ErofsOptions in manifest (osbuild/images#2212) - Author: Lukáš Zapletal, Reviewers: Simon de Vlieger, Tomáš Hozza - schutzbot: bump terraform hash (osbuild/images#2205) - Author: Simon de Vlieger, Reviewers: Anna Vítová, Lukáš Zapletal — Somewhere on the Internet, 2026-02-19 --- tag v0.244.0 Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com> Changes with 0.244.0 ---------------- - pkg/osbuild/rpm: don't collect GPG keys from repos with CheckGPG=false (osbuild/images#2203) - Author: Tomáš Hozza, Reviewers: Achilleas Koutsou, Lukáš Zapletal — Somewhere on the Internet, 2026-02-19 ---

supakeen self-requested a review February 12, 2026 16:05

supakeen reviewed Feb 12, 2026

View reviewed changes

pkg/distro/generic/images.go Show resolved Hide resolved

pkg/distro/generic/images.go Outdated Show resolved Hide resolved

avitova commented Feb 13, 2026

View reviewed changes

pkg/distro/defs/loader_test.go Show resolved Hide resolved

supakeen reviewed Feb 16, 2026

View reviewed changes

pkg/distro/defs/loader_test.go Show resolved Hide resolved

pkg/distro/defs/loader_test.go Show resolved Hide resolved

pkg/distro/generic/images.go Show resolved Hide resolved

avitova force-pushed the erofs branch from 93cb8b3 to 4aa04c4 Compare February 17, 2026 10:08

avitova commented Feb 17, 2026

View reviewed changes

data/distrodefs/fedora/imagetypes.yaml Show resolved Hide resolved

avitova force-pushed the erofs branch from 4aa04c4 to 3ef199f Compare February 17, 2026 10:23

supakeen force-pushed the erofs branch from 3ef199f to 23d459a Compare February 17, 2026 10:52

supakeen reviewed Feb 17, 2026

View reviewed changes

avitova force-pushed the erofs branch from 23d459a to 9fe8299 Compare February 17, 2026 11:41

avitova marked this pull request as ready for review February 17, 2026 11:43

avitova requested a review from a team as a code owner February 17, 2026 11:43

avitova requested review from bcl, croissanne and thozza February 17, 2026 11:43

supakeen requested changes Feb 17, 2026

View reviewed changes

avitova force-pushed the erofs branch from 9fe8299 to 7d2e536 Compare February 17, 2026 12:25

supakeen reviewed Feb 17, 2026

View reviewed changes

data/distrodefs/fedora/imagetypes.yaml Outdated Show resolved Hide resolved

avitova force-pushed the erofs branch 2 times, most recently from fad32f6 to 533efba Compare February 17, 2026 12:31

supakeen reviewed Feb 17, 2026

View reviewed changes

pkg/manifest/anaconda_installer_iso_tree.go Outdated Show resolved Hide resolved

supakeen reviewed Feb 17, 2026

View reviewed changes

pkg/manifest/iso_tree.go Outdated Show resolved Hide resolved

achilleas-k self-requested a review February 17, 2026 12:35

avitova force-pushed the erofs branch 2 times, most recently from 31d163a to 57b21e3 Compare February 17, 2026 12:44

supakeen reviewed Feb 17, 2026

View reviewed changes

pkg/manifest/anaconda_installer_iso_tree.go Outdated Show resolved Hide resolved

pkg/manifest/iso_tree.go Outdated Show resolved Hide resolved

avitova force-pushed the erofs branch from 57b21e3 to 1522995 Compare February 17, 2026 13:23

avitova commented Feb 17, 2026

View reviewed changes

achilleas-k previously approved these changes Feb 17, 2026

View reviewed changes

avitova added 3 commits February 17, 2026 17:45

chore: remove redundant type

e480787

fix: check for nil pointer before access

fc26df3

distro: add configurable erofs into anaconda inst

c82f5f8

This commit enables configuration of erofs extended options, compression and clustersize fields.

supakeen force-pushed the erofs branch from 1522995 to 125a717 Compare February 17, 2026 16:45

data/distrodefs: configure Fedora to use erofs

7f02de4

supakeen dismissed stale reviews from achilleas-k and themself via 7f02de4 February 17, 2026 19:05

supakeen force-pushed the erofs branch from 125a717 to 7f02de4 Compare February 17, 2026 19:05

supakeen requested a review from achilleas-k February 17, 2026 19:07

supakeen approved these changes Feb 17, 2026

View reviewed changes

bcl reviewed Feb 18, 2026

View reviewed changes

supakeen approved these changes Feb 18, 2026

View reviewed changes

achilleas-k approved these changes Feb 18, 2026

View reviewed changes

supakeen added this pull request to the merge queue Feb 18, 2026

Merged via the queue into osbuild:main with commit aa8e8f6 Feb 18, 2026
25 checks passed

supakeen mentioned this pull request Feb 18, 2026

fedora: atomic installer default config and erofs (HMS-10220) #2209

Merged

achilleas-k mentioned this pull request Feb 19, 2026

go.mod: bump osbuild/images to v0.244.0 osbuild/osbuild-composer#5033

Merged

achilleas-k mentioned this pull request Feb 19, 2026

go.mod: update osbuild/images to v0.243.0 osbuild/image-builder-cli#457

Merged

Conversation

avitova commented Feb 12, 2026

Uh oh!

supakeen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

supakeen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

supakeen left a comment

Choose a reason for hiding this comment

Uh oh!

supakeen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

avitova left a comment

Choose a reason for hiding this comment

Uh oh!

achilleas-k left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

supakeen commented Feb 17, 2026

Uh oh!

supakeen commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

supakeen commented Feb 17, 2026 •

edited

Loading