Skip to content

Join/part tab style still worked with /ignore enabled #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
osa1 merged 1 commit into from
Dec 25, 2020
Merged

Join/part tab style still worked with /ignore enabled #293

osa1 merged 1 commit into from
Dec 25, 2020

Conversation

@trevarj
Copy link
Contributor

@trevarj trevarj commented Dec 25, 2020

Also renamed the function get_ignore_state -> is_showing_status because it was a bit confusing

Closes #291

osa1
osa1 approved these changes Dec 25, 2020
View reviewed changes
Copy link
Owner

@osa1 osa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll merge this today.

@osa1 osa1 merged commit 3222b41 into osa1:master Dec 25, 2020
osa1 added a commit that referenced this pull request Dec 25, 2020
@osa1
Update CHANGELOG for #293
0144a84
@trevarj trevarj deleted the ignore-joinpart-fix branch August 29, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@osa1 osa1 osa1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tabs still change color for join/part even if /ignore is enabled

2 participants

@trevarj @osa1