Skip to content

Tabs still change color for join/part even if /ignore is enabled #291

@trevarj

Description

@trevarj

Problem: when /ignore is enabled, tabs should not change color on the joining or parting of a user

This is my fault, I think. When I added the JoinOrPart tab style I didn't check this scenario.

It comes from these two identical lines in conn.rs :

ui.set_tab_style(TabStyle::JoinOrPart, &MsgTarget::Chan { serv, chan: &chan })

Doesn't look like there's a way to get the ignore from there without adding another function on ui, so you could probably change it here in tui.rs:

    pub(crate) fn set_tab_style(&mut self, style: TabStyle, target: &MsgTarget) {
        self.apply_to_target(target, &|tab: &mut Tab, is_active: bool| {
            if !is_active && tab.style < style {
                tab.set_style(style);
            }
        });
    }

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions