Skip to content

build: bump github.com/opencontainers/image-spec to v1.1.0-rc5#615

Merged
Wwwsylvia merged 3 commits into
oras-project:mainfrom
Wwwsylvia:spec_rc5
Oct 12, 2023
Merged

build: bump github.com/opencontainers/image-spec to v1.1.0-rc5#615
Wwwsylvia merged 3 commits into
oras-project:mainfrom
Wwwsylvia:spec_rc5

Conversation

@Wwwsylvia

Copy link
Copy Markdown
Member
  1. Bump github.com/opencontainers/image-spec to v1.1.0-rc5 in go mod
  2. Replace "index.json" and "blobs" with corresponding constants in the spec
  3. Fix testable examples that broke by the spec change - MediaType became a required field in Descriptor

Resolve: #599

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@codecov-commenter

codecov-commenter commented Oct 11, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.59%. Comparing base (6dfbe52) to head (05530e9).
⚠️ Report is 124 commits behind head on main.

Files with missing lines Patch % Lines
content/oci/oci.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #615   +/-   ##
=======================================
  Coverage   74.59%   74.59%           
=======================================
  Files          58       58           
  Lines        5313     5313           
=======================================
  Hits         3963     3963           
  Misses        995      995           
  Partials      355      355           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 86176e8 into oras-project:main Oct 12, 2023
@Wwwsylvia Wwwsylvia deleted the spec_rc5 branch October 12, 2023 06:59
Wwwsylvia added a commit to Wwwsylvia/oras-go that referenced this pull request Oct 19, 2023
…ras-project#615)

1. Bump `github.com/opencontainers/image-spec` to `v1.1.0-rc5` in go mod
2. Replace "index.json" and "blobs" with corresponding constants in the
spec
3. Fix testable examples that broke by the spec change - `MediaType`
became a required field in `Descriptor`

Resolve: oras-project#599
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
shizhMSFT pushed a commit that referenced this pull request Oct 20, 2023
)

1. Bump `github.com/opencontainers/image-spec` to `v1.1.0-rc5` in go mod
2. Replace "index.json" and "blobs" with corresponding constants in the
spec
3. Fix testable examples that broke by the spec change - `MediaType`
became a required field in `Descriptor`

Resolve: #599
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia Wwwsylvia mentioned this pull request Oct 20, 2023
4 tasks
@Wwwsylvia Wwwsylvia mentioned this pull request Jan 26, 2024
4 tasks
@sparr

sparr commented Oct 17, 2024

Copy link
Copy Markdown
Contributor

Thanks for this. Glad to see #520 and opencontainers/image-spec#1071 come full circle :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to image-spec v1.1.0-rc5

4 participants