Add constants for "index.json" and "blobs" alongside "oci-layout" as parts of the layout specification#1071
Merged
Merged
Conversation
sudo-bmitch
requested changes
Jun 2, 2023
sudo-bmitch
left a comment
Contributor
There was a problem hiding this comment.
Just a few minor comment nits. While we're here, I think we should also fix line 18. My attempt would look like:
// ImageLayoutFile is the file name containing ImageLayout in an OCI Image Layout
alongside "oci-layout" as parts of the layout specification Signed-off-by: Clarence "Sparr" Risher <clrnc@amazon.com>
TerryHowe
approved these changes
Jun 3, 2023
TerryHowe
left a comment
There was a problem hiding this comment.
/lgtm
although obviously not a maintainer
tianon
approved these changes
Jun 23, 2023
Member
|
(I don't think I personally plan to use these in the tools I've written that currently hard-code these values, but I do think adding them increases the consistency of the constants we provide ❤️) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The layout spec requires three named files/directories. The
oci-layoutfile name is already exposed as a constant from this package. This PR adds exported constants forindex.jsonandblobs.Closes #1069