Skip to content

fix: fix failed Windows unit test#1352

Merged
qweeah merged 2 commits into
oras-project:mainfrom
wangxiaoxuan273:windows
Apr 17, 2024
Merged

fix: fix failed Windows unit test#1352
qweeah merged 2 commits into
oras-project:mainfrom
wangxiaoxuan273:windows

Conversation

@wangxiaoxuan273

@wangxiaoxuan273 wangxiaoxuan273 commented Apr 17, 2024

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1347

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
@codecov

codecov Bot commented Apr 17, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.49%. Comparing base (28c8514) to head (0afa784).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1352   +/-   ##
=======================================
  Coverage   84.49%   84.49%           
=======================================
  Files         103      103           
  Lines        3677     3677           
=======================================
  Hits         3107     3107           
  Misses        340      340           
  Partials      230      230           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qweeah qweeah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 7ffe63e into oras-project:main Apr 17, 2024
@wangxiaoxuan273 wangxiaoxuan273 deleted the windows branch April 17, 2024 08:25
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows unit tests cannot be compiled

2 participants