Skip to content

Fix type checking in optuna.artifacts._download.py#6177

Merged
nabenabe0928 merged 2 commits intooptuna:masterfrom
dross20:fix-type-checking-_download
Jun 25, 2025
Merged

Fix type checking in optuna.artifacts._download.py#6177
nabenabe0928 merged 2 commits intooptuna:masterfrom
dross20:fix-type-checking-_download

Conversation

@dross20
Copy link
Copy Markdown
Contributor

@dross20 dross20 commented Jun 25, 2025

Motivation

This PR addresses #6029.

Description of the changes

Fixes the circular import in optuna.artifacts._download.py.

@nzw0301 nzw0301 added the code-fix Change that does not change the behavior, such as code refactoring. label Jun 25, 2025
Copy link
Copy Markdown
Member

@nzw0301 nzw0301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Copy Markdown
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nabenabe0928 nabenabe0928 merged commit a6487ff into optuna:master Jun 25, 2025
14 checks passed
@nzw0301 nzw0301 added this to the v4.5.0 milestone Jun 25, 2025
dhyeyinf pushed a commit to dhyeyinf/optuna that referenced this pull request Jun 26, 2025
Fix type checking in `optuna.artifacts._download.py`
dhyeyinf pushed a commit to dhyeyinf/optuna that referenced this pull request Jun 26, 2025
Fix type checking in `optuna.artifacts._download.py`
dhyeyinf pushed a commit to dhyeyinf/optuna that referenced this pull request Jun 26, 2025
Fix type checking in `optuna.artifacts._download.py`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-fix Change that does not change the behavior, such as code refactoring.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants