-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Open
Labels
code-fixChange that does not change the behavior, such as code refactoring.Change that does not change the behavior, such as code refactoring.contribution-welcomeIssue that welcomes contribution.Issue that welcomes contribution.good first issueGood first issue for contribution.Good first issue for contribution.
Description
Important
In order to reduce review costs and to encourage more contributors to work on it, please, as a rule, fix one file per PR. After one PR submission, please tackle other issues.
Motivation
Some modules are imported only for type checking, but this may cause circular import, leading to an error.
Although such an error is not a big deal for most cases, it may require annoying changes sometimes as in:
The issue above motivates using TYPE_CHECKING.
Suggestion
First, we can check which files to modify by the following:
$ ruff check . --select TCHAdditional context (optional)
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
code-fixChange that does not change the behavior, such as code refactoring.Change that does not change the behavior, such as code refactoring.contribution-welcomeIssue that welcomes contribution.Issue that welcomes contribution.good first issueGood first issue for contribution.Good first issue for contribution.