Skip to content

Fix type checking in optuna._callbacks.py#6030

Merged
y0z merged 1 commit intooptuna:masterfrom
nabenabe0928:code-fix/fix-type-checking-in-callbacks
Apr 2, 2025
Merged

Fix type checking in optuna._callbacks.py#6030
y0z merged 1 commit intooptuna:masterfrom
nabenabe0928:code-fix/fix-type-checking-in-callbacks

Conversation

@nabenabe0928
Copy link
Copy Markdown
Contributor

Motivation

This PR partially resolves:

Description of the changes

  • Fix callbacks.py

@nabenabe0928 nabenabe0928 changed the title Fix type checking in callbacks.py Fix type checking in optuna._callbacks.py Apr 1, 2025
@nabenabe0928
Copy link
Copy Markdown
Contributor Author

@y0z @gen740 Could you review this PR?

Copy link
Copy Markdown
Member

@gen740 gen740 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member

@y0z y0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0z y0z unassigned y0z and gen740 Apr 2, 2025
@y0z y0z added the enhancement Change that does not break compatibility and not affect public interfaces, but improves performance. label Apr 2, 2025
@y0z y0z added this to the v4.3.0 milestone Apr 2, 2025
@y0z y0z merged commit 0798e45 into optuna:master Apr 2, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Change that does not break compatibility and not affect public interfaces, but improves performance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants