Use TYPE_CHECKING for Study in samplers#5391
Merged
eukaryo merged 5 commits intooptuna:masterfrom Apr 17, 2024
Merged
Conversation
Merged
Contributor
Author
|
Although I made everything The former is more concise while the latter allows developers to use the direct link to I would like to ask @not522 which one is better. |
Contributor
Author
Member
|
I recommend |
99852ec to
fc106f5
Compare
not522
reviewed
Apr 17, 2024
optuna/study/study.py
Outdated
|
|
||
|
|
||
| ObjectiveFuncType = Callable[[trial_module.Trial], Union[float, Sequence[float]]] | ||
| ObjectiveFuncType = Callable[["Trial"], Union[float, Sequence[float]]] |
Member
There was a problem hiding this comment.
How about moving it under if TYPE_CHECKING:?
Suggested change
| ObjectiveFuncType = Callable[["Trial"], Union[float, Sequence[float]]] | |
| ObjectiveFuncType = Callable[[Trial], Union[float, Sequence[float]]] |
Contributor
Author
There was a problem hiding this comment.
Oh, I did not know that it works in this way!
I reflected your suggestion!
Co-authored-by: Naoto Mizuno <gobou522@gmail.com>
eukaryo
approved these changes
Apr 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As circular references happen in
samplerswhen removingmulti_objectivedue toStudy, I replacedStudyinsamplerswith"Study"usingTYPE_CHECKING.Description of the changes
Replace all
Studyinsamplerswith"Study"usingTYPE_CHECKING.