[release-4.16] OCPBUGS-53242: Ensure that PSA label is latest instead of pinning versions#612
Conversation
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-53179 has been cloned as Jira Issue OCPBUGS-53242. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-53242, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@camilamacedo86: This pull request references Jira Issue OCPBUGS-53242, which is valid. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
anik120
left a comment
There was a problem hiding this comment.
@camilamacedo86 https://issues.redhat.com/browse/OCPBUGS-41849 has "Affects version: 4.17", are we sure we want this in 4.16 too?
|
Test pass, details: https://issues.redhat.com/browse/OCPBUGS-53242 |
|
/hold |
That's a good point! That's OK if we backport it to 4.16.z. However, it's better to align with the Auth team, + @camilamacedo86 What do you think? |
|
Do we really need to fix this for 4.16? Regarding your comment: "However, it's better to align with the Auth team,"—why do you think alignment with the Auth team is necessary? So, what would be the key difference between setting the latest version for higher releases but not for 4.16? Why do you think it's acceptable from 4.17 onwards but not for 4.16? What is your specific concern? PS: I do not understand why you think that is fine we have latest from 4.17 and not at 4.16, could you please help me understand it ? |
|
@camilamacedo86 see the comments by Xingxing Xia in https://issues.redhat.com/browse/OCPBUGS-41849. Looks like a 4.16 cluster had 1.24 pinned to it, was upgraded to 4.17 and Going by just the paperwork there, it looks like the intention is to go only as far back as 4.17. Is there any restrictions technically from back porting this to 4.16? I don't know. Just going with the paper work here, which as a reviewer is easier to adhere to, than verify if things will break if this is back ported to 4.16. |
|
Thank you both a lot that is my question:
|
|
As https://issues.redhat.com/browse/OCPBUGS-41849 mentioned |
|
After discussion, it was decided that we will not backport to 4.16 |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-53242. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This is an automated cherry-pick of #607
/assign openshift-cherrypick-robot