Skip to content

[release-4.16] OCPBUGS-53242: Ensure that PSA label is latest instead of pinning versions#612

Closed
openshift-cherrypick-robot wants to merge 1 commit into
operator-framework:release-4.16from
openshift-cherrypick-robot:cherry-pick-607-to-release-4.16
Closed

[release-4.16] OCPBUGS-53242: Ensure that PSA label is latest instead of pinning versions#612
openshift-cherrypick-robot wants to merge 1 commit into
operator-framework:release-4.16from
openshift-cherrypick-robot:cherry-pick-607-to-release-4.16

Conversation

@openshift-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #607

/assign openshift-cherrypick-robot

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-53179 has been cloned as Jira Issue OCPBUGS-53242. Will retitle bug to link to clone.
/retitle [release-4.16] OCPBUGS-53242: Ensure that PSA label is latest instead of pinning versions

Details

In response to this:

This is an automated cherry-pick of #607

/assign openshift-cherrypick-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Mar 18, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign joelanford for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot changed the title [release-4.16] OCPBUGS-53179: Ensure that PSA label is latest instead of pinning versions [release-4.16] OCPBUGS-53242: Ensure that PSA label is latest instead of pinning versions Mar 18, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 18, 2025
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-53242, which is invalid:

  • expected dependent Jira Issue OCPBUGS-53179 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #607

/assign openshift-cherrypick-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Mar 19, 2025
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@camilamacedo86: This pull request references Jira Issue OCPBUGS-53242, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-53179 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-53179 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 19, 2025

@anik120 anik120 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camilamacedo86 https://issues.redhat.com/browse/OCPBUGS-41849 has "Affects version: 4.17", are we sure we want this in 4.16 too?

@jianzhangbjz

Copy link
Copy Markdown
Contributor

Test pass, details: https://issues.redhat.com/browse/OCPBUGS-53242
/label qe-approved
/label cherry-pick-approved

@openshift-ci openshift-ci Bot added qe-approved Signifies that QE has signed off on this PR cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Mar 20, 2025
@jianzhangbjz

Copy link
Copy Markdown
Contributor

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2025
@jianzhangbjz

Copy link
Copy Markdown
Contributor

@camilamacedo86 https://issues.redhat.com/browse/OCPBUGS-41849 has "Affects version: 4.17", are we sure we want this in 4.16 too?

That's a good point! That's OK if we backport it to 4.16.z. However, it's better to align with the Auth team, + @camilamacedo86 What do you think?

@camilamacedo86

camilamacedo86 commented Mar 20, 2025

Copy link
Copy Markdown
Contributor

Hi @jianzhangbjz, @anik120

Do we really need to fix this for 4.16?
What Kubernetes version is used for the OCP 4.16 release?

Regarding your comment: "However, it's better to align with the Auth team,"—why do you think alignment with the Auth team is necessary?

So, what would be the key difference between setting the latest version for higher releases but not for 4.16? Why do you think it's acceptable from 4.17 onwards but not for 4.16? What is your specific concern?

PS: I do not understand why you think that is fine we have latest from 4.17 and not at 4.16, could you please help me understand it ?

@anik120

anik120 commented Mar 20, 2025

Copy link
Copy Markdown
Member

@camilamacedo86 see the comments by Xingxing Xia in https://issues.redhat.com/browse/OCPBUGS-41849. Looks like a 4.16 cluster had 1.24 pinned to it, was upgraded to 4.17 and latest was seen, which passed the test.

Going by just the paperwork there, it looks like the intention is to go only as far back as 4.17.

Is there any restrictions technically from back porting this to 4.16? I don't know. Just going with the paper work here, which as a reviewer is easier to adhere to, than verify if things will break if this is back ported to 4.16.

@camilamacedo86

Copy link
Copy Markdown
Contributor

Hi @anik120 @jianzhangbjz

Thank you both a lot that is my question:

  • what is the concern we have in cherry-pick to 4.16? That is not was requested by QE?
  • what do we need to check with Auth-Team exactly?

@jianzhangbjz

Copy link
Copy Markdown
Contributor

As https://issues.redhat.com/browse/OCPBUGS-41849 mentioned We kept it at "v1.24" due to potential issues with HyperShift.. Now, that bug has been fixed. However, they didn't backport it since there is no strong requirement.
So, as I mentioned above, whether backporting it to 4.16.z or not is ok for me.

@camilamacedo86

Copy link
Copy Markdown
Contributor

After discussion, it was decided that we will not backport to 4.16 
more info: https://redhat-internal.slack.com/archives/C06KP34REFJ/p1744735179579959

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-53242. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #607

/assign openshift-cherrypick-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants