The SHA256 is not a mandatory digest for DSA.#9015
The SHA256 is not a mandatory digest for DSA.#9015t8m wants to merge 1 commit intoopenssl:masterfrom
Conversation
The openssl#7408 implemented mandatory digest checking in TLS. However this broke compatibility of DSS support with GnuTLS which supports only SHA1 with DSS. There is no reason why SHA256 would be a mandatory digest for DSA as other digests in SHA family can be used as well.
|
1.1.1 seems to have this fix already. |
|
I am not sure how it was backported to multiple branches in #7408, but not put into master? |
I do not see it. Did you look at ec_ameth.c perhaps? |
|
Yes, the #7408 is backported to both 1.1.1 and 1.0.2. But DSA has SHA-256 as mandatory on all active branches. Given this is a bugfix and not security issue fix, I am going to put it on master and 1.1.1 only. |
|
Did you mean to close this...its not on master yet? |
|
@mattcaswell for some reason, the master branch got force-pushed and Tomas' commit was lost. |
|
You can find a GitHub notification about this event at #9029 |
Ah. My guess is that @t8m pushed to the github mirror master rather than the real master. Then when another commit got pushed to the real master it got overwritten when the mirror was updated. |
|
Similarly I don't see this commit in the 1.1.1 branch, so my guess is that the same thing happened there. |
|
That sounds like a reasonable explanation. |
|
Yes, there they are, thrown off the track:
|
|
Ah of course, not sure how I made this :( I am going to push to the right repo now. |
The #7408 implemented mandatory digest checking in TLS. However this broke compatibility of DSS support with GnuTLS which supports only SHA1 with DSS. There is no reason why SHA256 would be a mandatory digest for DSA as other digests in SHA family can be used as well. Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from #9015)
The #7408 implemented mandatory digest checking in TLS. However this broke compatibility of DSS support with GnuTLS which supports only SHA1 with DSS. There is no reason why SHA256 would be a mandatory digest for DSA as other digests in SHA family can be used as well. Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from #9015) (cherry picked from commit cd4c83b)
|
Hopefully the mess is cleared up now. I've mistakenly cloned locally wrong repo for the pushes before. |
|
Yes, looks good now. |
The #7408 implemented mandatory digest checking in TLS. However this broke compatibility of DSS support with GnuTLS which supports only SHA1 with DSS. There is no reason why SHA256 would be a mandatory digest for DSA as other digests in SHA family can be used as well. Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from openssl/openssl#9015) (cherry picked from commit cd4c83b52423008391b50abcccf18a7d8fcce03b)
The #7408 implemented mandatory digest checking in TLS. However this broke compatibility of DSS support with GnuTLS which supports only SHA1 with DSS. There is no reason why SHA256 would be a mandatory digest for DSA as other digests in SHA family can be used as well. Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from openssl/openssl#9015) (cherry picked from commit cd4c83b52423008391b50abcccf18a7d8fcce03b)
The #7408 implemented mandatory digest checking in TLS.
However this broke compatibility of DSS support with GnuTLS
which supports only SHA1 with DSS.
There is no reason why SHA256 would be a mandatory digest
for DSA as other digests in SHA family can be used as well.