Skip to content

crypto/conf: openssl_config_int() returns unitialized value#9029

Closed
mspncp wants to merge 1 commit intoopenssl:masterfrom
mspncp:pr-openssl_config_int-fix-unitialized-read
Closed

crypto/conf: openssl_config_int() returns unitialized value#9029
mspncp wants to merge 1 commit intoopenssl:masterfrom
mspncp:pr-openssl_config_int-fix-unitialized-read

Conversation

@mspncp
Copy link
Contributor

@mspncp mspncp commented May 28, 2019

openssl_config_int() returns the uninitialized variable ret when compiled with OPENSSL_SYS_UEFI.

Fixes #9026

@mspncp
crypto/conf: openssl_config_int() returns unitialized value
4c72e8b 
openssl_config_int() returns the uninitialized variable `ret`
when compiled with OPENSSL_SYS_UEFI.

Fixes openssl#9026
@mspncp mspncp added branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) branch: master Applies to master branch labels May 28, 2019
@mspncp mspncp mentioned this pull request May 28, 2019
Closed
@mspncp mspncp mentioned this pull request May 28, 2019
Closed
@mspncp
Copy link
Contributor Author

mspncp commented May 28, 2019

Travis failure is related to #9022.

@mspncp mspncp added the approval: review pending This pull request needs review by a committer label May 28, 2019
slontis
slontis approved these changes May 28, 2019
View reviewed changes
Copy link
Member

@slontis slontis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess coverity wont pick up these kind of cases containing #ifdefs

@t-j-h t-j-h added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels May 28, 2019
levitte pushed a commit that referenced this pull request May 29, 2019
@mspncp @slontis
crypto/conf: openssl_config_int() returns unitialized value
f4a9650 
openssl_config_int() returns the uninitialized variable `ret`
when compiled with OPENSSL_SYS_UEFI.

Fixes #9026

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #9029)
levitte pushed a commit that referenced this pull request May 29, 2019
@mspncp @slontis
crypto/conf: openssl_config_int() returns unitialized value
23373fe 
openssl_config_int() returns the uninitialized variable `ret`
when compiled with OPENSSL_SYS_UEFI.

Fixes #9026

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #9029)

(cherry picked from commit f4a9650)
@slontis
Copy link
Member

slontis commented May 29, 2019

Merged. Thanks @lersek and @mspncp

@slontis slontis closed this May 29, 2019
@mspncp mspncp deleted the pr-openssl_config_int-fix-unitialized-read branch June 27, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-j-h t-j-h t-j-h approved these changes

@slontis slontis slontis approved these changes

Assignees

No one assigned

Labels

approval: done This pull request has the required number of approvals branch: master Applies to master branch branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

openssl_config_int() may return indeterminate value on OPENSSL_SYS_UEFI post 25eb9299cec4

3 participants

@mspncp @slontis @t-j-h