Closed
Conversation
99080fa to
1a1d53f
Compare
When trying 'make -j{n} install', you may occasionally run into
trouble because to sub-targets (install_dev and install_runtime) try
to install the same shared libraries. That makes parallel install
difficult.
This is solved by dividing install_runtime into two parts, one for
libraries and one for programs, and have install_dev depend on
install_runtime_libs instead of installing the shared runtime
libraries itself.
Fixes openssl#7466
We only had the main 'install' target depend on 'all'. This changes the dependencies so targets like install_dev, install_runtime_libs, install_engines and install_programs depend on build targets that are correspond to them more specifically. This increases the parallel possibilities. Fixes openssl#7466
1a1d53f to
7d901a5
Compare
paulidale
approved these changes
Nov 9, 2018
levitte
added a commit
that referenced
this pull request
Nov 9, 2018
When trying 'make -j{n} install', you may occasionally run into
trouble because to sub-targets (install_dev and install_runtime) try
to install the same shared libraries. That makes parallel install
difficult.
This is solved by dividing install_runtime into two parts, one for
libraries and one for programs, and have install_dev depend on
install_runtime_libs instead of installing the shared runtime
libraries itself.
Fixes #7466
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from #7583)
levitte
added a commit
that referenced
this pull request
Nov 9, 2018
We only had the main 'install' target depend on 'all'. This changes the dependencies so targets like install_dev, install_runtime_libs, install_engines and install_programs depend on build targets that are correspond to them more specifically. This increases the parallel possibilities. Fixes #7466 Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from #7583)
levitte
added a commit
that referenced
this pull request
Nov 9, 2018
When trying 'make -j{n} install', you may occasionally run into
trouble because to sub-targets (install_dev and install_runtime) try
to install the same shared libraries. That makes parallel install
difficult.
This is solved by dividing install_runtime into two parts, one for
libraries and one for programs, and have install_dev depend on
install_runtime_libs instead of installing the shared runtime
libraries itself.
Fixes #7466
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from #7583)
(cherry picked from commit c1123d9)
levitte
added a commit
that referenced
this pull request
Nov 9, 2018
We only had the main 'install' target depend on 'all'. This changes the dependencies so targets like install_dev, install_runtime_libs, install_engines and install_programs depend on build targets that are correspond to them more specifically. This increases the parallel possibilities. Fixes #7466 Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from #7583) (cherry picked from commit e8d01a6)
levitte
added a commit
that referenced
this pull request
Nov 9, 2018
When trying 'make -j{n} install', you may occasionally run into
trouble because to sub-targets (install_dev and install_runtime) try
to install the same shared libraries. That makes parallel install
difficult.
This is solved by dividing install_runtime into two parts, one for
libraries and one for programs, and have install_dev depend on
install_runtime_libs instead of installing the shared runtime
libraries itself.
Fixes #7466
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from #7583)
(cherry picked from commit c1123d9)
levitte
added a commit
that referenced
this pull request
Nov 9, 2018
We only had the main 'install' target depend on 'all'. This changes the dependencies so targets like install_dev, install_runtime_libs, install_engines and install_programs depend on build targets that are correspond to them more specifically. This increases the parallel possibilities. Fixes #7466 Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from #7583) (cherry picked from commit e8d01a6)
Member
Author
|
Merged. master: 1.1.1: 1.1.0: |
DomT4
added a commit
to DomT4/homebrew-core-1
that referenced
this pull request
Apr 28, 2021
The issues around parallel builds were resolved in 2018 via openssl/openssl#7583 and the referenced commits. Sadly the tests still take 45 years to get through but this fairly significantly speeds up the build time. Before: ==> Summary /opt/homebrew/Cellar/openssl@1.1/1.1.1k: 8,064 files, 17.9MB, built in 7 minutes 40 seconds After: ==> Summary /opt/homebrew/Cellar/openssl@1.1/1.1.1k: 8,064 files, 17.9MB, built in 4 minutes 35 seconds
5 tasks
carlocab
pushed a commit
to Homebrew/homebrew-core
that referenced
this pull request
Apr 30, 2021
The issues around parallel builds were resolved in 2018 via openssl/openssl#7583 and the referenced commits. Sadly the tests still take 45 years to get through but this fairly significantly speeds up the build time. Before: ==> Summary /opt/homebrew/Cellar/openssl@1.1/1.1.1k: 8,064 files, 17.9MB, built in 7 minutes 40 seconds After: ==> Summary /opt/homebrew/Cellar/openssl@1.1/1.1.1k: 8,064 files, 17.9MB, built in 4 minutes 35 seconds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying 'make -j{n} install', you may occasionally run into
trouble because to sub-targets (install_dev and install_runtime) try
to install the same shared libraries. That makes parallel install
difficult.
This is solved by dividing install_runtime into two parts, one for
libraries and one for programs, and have install_dev depend on
install_runtime_libs instead of installing the shared runtime
libraries itself.
Furthermore, we only had the main 'install' target depend on 'all'.
Here, we change the dependencies so targets like
install_dev,install_runtime_libs,install_enginesandinstall_programsdepend on build targets that are correspond to them more specifically.
This increases the parallel possibilities.
Fixes #7466