Skip to content

openssl@1.1: re-parallelise build/install#76174

Merged
carlocab merged 1 commit intoHomebrew:masterfrom
DomT4:openssl
Apr 30, 2021
Merged

openssl@1.1: re-parallelise build/install#76174
carlocab merged 1 commit intoHomebrew:masterfrom
DomT4:openssl

Conversation

@DomT4
Copy link
Copy Markdown
Contributor

@DomT4 DomT4 commented Apr 28, 2021

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

The issues around parallel builds were resolved in 2018 via openssl/openssl#7583 and the referenced commits.

Sadly the tests still take 45 years to get through but this fairly significantly speeds up the build time.

Before:

==> Summary
/opt/homebrew/Cellar/openssl@1.1/1.1.1k: 8,064 files, 17.9MB, built in 7 minutes 40 seconds

After:

==> Summary
/opt/homebrew/Cellar/openssl@1.1/1.1.1k: 8,064 files, 17.9MB, built in 4 minutes 35 seconds

@DomT4
openssl@1.1: re-parallelise build/install
42b5473 
The issues around parallel builds were resolved in 2018 via
openssl/openssl#7583 and the referenced
commits.

Sadly the tests still take 45 years to get through but this fairly
significantly speeds up the build time.

Before:
==> Summary
/opt/homebrew/Cellar/openssl@1.1/1.1.1k: 8,064 files, 17.9MB, built in 7 minutes 40 seconds

After:
==> Summary
/opt/homebrew/Cellar/openssl@1.1/1.1.1k: 8,064 files, 17.9MB, built in 4 minutes 35 seconds
@DomT4
Copy link
Copy Markdown
Contributor Author

DomT4 commented Apr 29, 2021 •
edited
Loading

Failures here look unrelated. Not sure there's any way to stop GitHub's CI but someone might as well if you can; don't think this needs a full CI run to be merged really.

carlocab
carlocab approved these changes Apr 30, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@carlocab carlocab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the same failures as #75515 (except for llvm@11 on ARM, which has since been fixed). Most likely unrelated then.

Will double-check the failures one more time then merge.

Thanks @DomT4!

@carlocab carlocab merged commit 2bbdb49 into Homebrew:master Apr 30, 2021
@carlocab carlocab mentioned this pull request Apr 30, 2021
Closed
@DomT4
Copy link
Copy Markdown
Contributor Author

DomT4 commented Apr 30, 2021

Thanks @carlocab! ❤️. I notice all the Perl failures on ARM Big Sur are the same; is that a known issue/something that's been discussed somewhere?

@DomT4 DomT4 deleted the openssl branch April 30, 2021 19:39
@carlocab
Copy link
Copy Markdown
Member

carlocab commented Apr 30, 2021

Yea, probably from 11.3 bumping the default perl to 5.30 (from 5.28). It's mentioned in a couple of issues at Homebrew/brew.

@DomT4
Copy link
Copy Markdown
Contributor Author

DomT4 commented Apr 30, 2021

Is that going to essentially require every system-perl using formula to have its revision bumped or is there another plan in the offing?

@carlocab
Copy link
Copy Markdown
Member

carlocab commented Apr 30, 2021

That, and some messing around with shebangs to make sure that formulae use the version of system perl that we expect them to.

@Bo98
Copy link
Copy Markdown
Member

Bo98 commented Apr 30, 2021

Yes, revision bumps after Homebrew/brew#11286 is merged.

@github-actions github-actions bot added the outdated PR was locked due to age label May 31, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@carlocab carlocab carlocab approved these changes

Assignees

No one assigned

Labels

outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DomT4 @carlocab @Bo98