Fix BN doc #5151
Closed
Fix BN doc #5151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doc/crypto/BN_zero.pod
Outdated
Contributor
Author
There was a problem hiding this comment.
yeah, i suppose. but all three releases have the same wording.
doc/crypto/BN_zero.pod
Outdated
Backport from #5141
Contributor
Author
|
Updated commit pushed that addresses both comments. |
vdukhovni
reviewed
Jan 24, 2018
|
|
||
| If a B<BIGNUM> is equal to 0xffffffffL it can be represented as an | ||
| unsigned long but this value is also returned on error. | ||
| B<BN_ULONG> should probably be a typedef. |
There was a problem hiding this comment.
I think the should probably be a typedef comment should go. By now some feature tests likely exist that test for ifdef BN_ULONG, so it is too late to make this a type instead. Also, when we add new types, applications that support older releases can test for macros more easily than for new types (instead they'd need to test against the OPENSSL_VERSION_NUMBER that adds the new type).
So all in all while may at some point introduce new types as non-macros, this one should probably stay as-is long-term.
vdukhovni
approved these changes
Jan 24, 2018
Contributor
Author
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport from #5141