Improve some BN documentation. #5141
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-j-h
approved these changes
Jan 22, 2018
t-j-h
approved these changes
Jan 22, 2018
Thanks to Nicolas Schodet for pointing this out.
Contributor
Author
|
sorry, one last time please @t-j-h :) |
kroeckx
reviewed
Jan 22, 2018
| BN_get_word() returns the value B<a>, and 0xffffffffL if B<a> cannot | ||
| be represented as an unsigned long. | ||
| BN_get_word() returns the value B<a>, or all-bits-set if B<a> cannot | ||
| be represented as a single integer. |
Member
There was a problem hiding this comment.
So how does one check this in a portable way?
Contributor
Author
There was a problem hiding this comment.
~(BN_LONG)0 or if retval+1==0
Contributor
|
Didn't this whole exercise start out from a complaint that BN_LONG is not a thing in the public headers anymore (and in fact not at all, since commit 94af0cd, by you)? |
Contributor
Author
|
I think you read too quickly; BN_ULONG not BN_LONG :) |
t-j-h
approved these changes
Jan 23, 2018
levitte
pushed a commit
that referenced
this pull request
Jan 23, 2018
Thanks to Nicolas Schodet for pointing this out. Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from #5141)
Contributor
Author
|
Merged to master. Separate PR coming for 1.1.0/1.0.2 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to Nicolas Schodet for pointing this out.
Fixes #5066. For all releases.