Skip to content

Remove unicode characters from source #4879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
levitte wants to merge 1 commit into from
Closed

Remove unicode characters from source #4879

levitte wants to merge 1 commit into from

Conversation

@levitte
Copy link
Member

@levitte levitte commented Dec 8, 2017

Some compilers react badly to non-ASCII characters

Fixes #4877

@levitte
Remove unicode characters from source
54220be 
Some compilers react badly to non-ASCII characters

Fixes openssl#4877
@levitte levitte added branch: 1.0.2 Applies to OpenSSL_1_0_2-stable branch (EOL) 1.1.0 branch: master Applies to master branch labels Dec 8, 2017
mattcaswell
mattcaswell approved these changes Dec 8, 2017
View reviewed changes
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could have sworn I've seen this before. Is there another PR somewhere for this waiting for merge?

@mattcaswell
Copy link
Member

mattcaswell commented Dec 8, 2017

Ah...yes...#4691 tackled another similar instance.

@levitte
Copy link
Member Author

levitte commented Dec 8, 2017

"similar" being the key here ;-)

levitte added a commit that referenced this pull request Dec 8, 2017
@levitte
Remove unicode characters from source
d68a0ea 
Some compilers react badly to non-ASCII characters

Fixes #4877

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #4879)
levitte added a commit that referenced this pull request Dec 8, 2017
@levitte
Remove unicode characters from source
fae00c9 
Some compilers react badly to non-ASCII characters

Fixes #4877

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #4879)

(cherry picked from commit d68a0ea)
levitte added a commit that referenced this pull request Dec 8, 2017
@levitte
Remove unicode characters from source
e167fd0 
Some compilers react badly to non-ASCII characters

Fixes #4877

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #4879)
@levitte
Copy link
Member Author

levitte commented Dec 8, 2017

Merged.

master: d68a0ea
1.1.0: fae00c9
1.0.2: e167fd0

@levitte levitte closed this Dec 8, 2017
@kaduk kaduk mentioned this pull request Oct 29, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees

No one assigned

Labels

branch: master Applies to master branch branch: 1.0.2 Applies to OpenSSL_1_0_2-stable branch (EOL)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@levitte @mattcaswell