Skip to content

lhash.c: Replace Unicode EN DASH with the ASCII char '-'. #4691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
qloong wants to merge 1 commit into from
Closed

lhash.c: Replace Unicode EN DASH with the ASCII char '-'. #4691

qloong wants to merge 1 commit into from

Conversation

@qloong
Copy link
Contributor

@qloong qloong commented Nov 7, 2017

  • addressing", Proc. 6th Conference on Very Large Databases: 212–223
    ^
    The EN DASH ('–') in this line is one UTF-8 character (hex: e2 80 93).
    Under some code page setting (e.g. 936), Visual Studio may report C4819
    warning: The file contains a character that cannot be represented in the
    current code page.

Replace this character with the ASCII char '-' (Hex Code: 2D).

Checklist
  • documentation is added or updated
  • tests are added or updated

lhash.c: Replace Unicode EN DASH with the ASCII char '-'.
3b5aaa2 
 * addressing", Proc. 6th Conference on Very Large Databases: 212–223
                                                                 ^
The EN DASH ('–') in this line is one UTF-8 character (hex: e2 80 93).
Under some code page setting (e.g. 936), Visual Studio may report C4819
warning: The file contains a character that cannot be represented in the
current code page.

Replace this character with the ASCII char '-' (Hex Code: 2D).
@mattcaswell mattcaswell added the approval: done This pull request has the required number of approvals label Nov 7, 2017
@openssl openssl deleted a comment from nahoMw Nov 11, 2017
@bernd-edlinger
Copy link
Member

bernd-edlinger commented Nov 11, 2017

BTW, the same character is here:

test/ossl_shim/ossl_shim.cc: // This prime number is 2^1024 + 643 – a value just above a power of two

@levitte
Copy link
Member

levitte commented Nov 11, 2017

test/ossl_shim/ossl_shim.cc is built under very specific (non-Windows) circumstances... so I don't think we need to care, but if someone does, it's just a PR away ;-)

@levitte levitte added branch: 1.0.2 Applies to OpenSSL_1_0_2-stable branch (EOL) 1.1.0 branch: master Applies to master branch labels Nov 11, 2017
@levitte
Copy link
Member

levitte commented Nov 11, 2017

BTW, this wasn't properly labeled... this should be applied on master, 1.1.0 and 1.0.2. Anyone disagree? (@t-j-h?)

@t-j-h
Copy link
Member

t-j-h commented Nov 11, 2017

Apply to all current branches.

levitte pushed a commit that referenced this pull request Nov 11, 2017
@levitte
lhash.c: Replace Unicode EN DASH with the ASCII char '-'.
b4d0fa4 
 * addressing", Proc. 6th Conference on Very Large Databases: 212–223
                                                                 ^
The EN DASH ('–') in this line is one UTF-8 character (hex: e2 80 93).
Under some code page setting (e.g. 936), Visual Studio may report C4819
warning: The file contains a character that cannot be represented in the
current code page.

Replace this character with the ASCII char '-' (Hex Code: 2D).

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #4691)
levitte pushed a commit that referenced this pull request Nov 11, 2017
@levitte
lhash.c: Replace Unicode EN DASH with the ASCII char '-'.
b571802 
 * addressing", Proc. 6th Conference on Very Large Databases: 212–223
                                                                 ^
The EN DASH ('–') in this line is one UTF-8 character (hex: e2 80 93).
Under some code page setting (e.g. 936), Visual Studio may report C4819
warning: The file contains a character that cannot be represented in the
current code page.

Replace this character with the ASCII char '-' (Hex Code: 2D).

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #4691)

(cherry picked from commit b4d0fa4)
levitte pushed a commit that referenced this pull request Nov 11, 2017
@levitte
lhash.c: Replace Unicode EN DASH with the ASCII char '-'.
45a58b1 
 * addressing", Proc. 6th Conference on Very Large Databases: 212–223
                                                                 ^
The EN DASH ('–') in this line is one UTF-8 character (hex: e2 80 93).
Under some code page setting (e.g. 936), Visual Studio may report C4819
warning: The file contains a character that cannot be represented in the
current code page.

Replace this character with the ASCII char '-' (Hex Code: 2D).

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #4691)

(cherry picked from commit b4d0fa4)
@levitte
Copy link
Member

levitte commented Nov 11, 2017

Merged.

master: b4d0fa4
1.1.0: b571802
1.0.2: 45a58b1

@levitte levitte closed this Nov 11, 2017
@mattcaswell mattcaswell mentioned this pull request Dec 8, 2017
Closed
qloong pushed a commit to tianocore/edk2 that referenced this pull request Dec 26, 2017
CryptoPkg/OpensslLib: Update OpenSSL version to 1.1.0g
dce03c4 
Update the supported OpenSSL version to the latest 1.1.0g (02-Nov-2017).
The changes includes:
 - Re-generate the OpensslLib[crypto].inf using process_files.pl script
   to reflect the openssl source changes.
 - Update OpenSSL-HOWTO.txt
 - On Visual Studio Build: adding "/wd4819" to disable one addition build
   warning issue, which was already fixed in OpenSSL-HEAD
   openssl/openssl#4691.
 - On GCC Build: openssl-1.1.0g introduced one additional build warning:
    ...\openssl\crypto\asn1\x_int64.c:105:32: error: format '%ld' expects
        argument of type 'long int', but argument 3 has type 'int64_t
        {aka long long int}' [-Werror=format=]
    return BIO_printf(out, "%"BIO_PRI64"d\n", **(int64_t **)pval);
                                ^
    Adding "-Wno-error=format" to GCC build flag to suppress this warning,
    since we have no real printf usage in BaseCryptLib, and BIO_printf()
    was already wrappered as the dummy implementation in CryptoPkg.

Cc: Ye Ting <ting.ye@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Long Qin <qin.long@intel.com>
Reviewed-by: Ye Ting <ting.ye@intel.com>
lcp pushed a commit to lcp/edk2 that referenced this pull request Jul 20, 2021
@lcp
CryptoPkg/OpensslLib: Update OpenSSL version to 1.1.0g
53c1166 
Update the supported OpenSSL version to the latest 1.1.0g (02-Nov-2017).
The changes includes:
 - Re-generate the OpensslLib[crypto].inf using process_files.pl script
   to reflect the openssl source changes.
 - Update OpenSSL-HOWTO.txt
 - On Visual Studio Build: adding "/wd4819" to disable one addition build
   warning issue, which was already fixed in OpenSSL-HEAD
   openssl/openssl#4691.
 - On GCC Build: openssl-1.1.0g introduced one additional build warning:
    ...\openssl\crypto\asn1\x_int64.c:105:32: error: format '%ld' expects
        argument of type 'long int', but argument 3 has type 'int64_t
        {aka long long int}' [-Werror=format=]
    return BIO_printf(out, "%"BIO_PRI64"d\n", **(int64_t **)pval);
                                ^
    Adding "-Wno-error=format" to GCC build flag to suppress this warning,
    since we have no real printf usage in BaseCryptLib, and BIO_printf()
    was already wrappered as the dummy implementation in CryptoPkg.

Cc: Ye Ting <ting.ye@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Long Qin <qin.long@intel.com>
Reviewed-by: Ye Ting <ting.ye@intel.com>
(cherry picked from commit dce03c4)
lcp pushed a commit to lcp/edk2 that referenced this pull request Jul 20, 2021
@lcp
CryptoPkg/OpensslLib: Update OpenSSL version to 1.1.0g
ec52de6 
Update the supported OpenSSL version to the latest 1.1.0g (02-Nov-2017).
The changes includes:
 - Re-generate the OpensslLib[crypto].inf using process_files.pl script
   to reflect the openssl source changes.
 - Update OpenSSL-HOWTO.txt
 - On Visual Studio Build: adding "/wd4819" to disable one addition build
   warning issue, which was already fixed in OpenSSL-HEAD
   openssl/openssl#4691.
 - On GCC Build: openssl-1.1.0g introduced one additional build warning:
    ...\openssl\crypto\asn1\x_int64.c:105:32: error: format '%ld' expects
        argument of type 'long int', but argument 3 has type 'int64_t
        {aka long long int}' [-Werror=format=]
    return BIO_printf(out, "%"BIO_PRI64"d\n", **(int64_t **)pval);
                                ^
    Adding "-Wno-error=format" to GCC build flag to suppress this warning,
    since we have no real printf usage in BaseCryptLib, and BIO_printf()
    was already wrappered as the dummy implementation in CryptoPkg.

Cc: Ye Ting <ting.ye@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Long Qin <qin.long@intel.com>
Reviewed-by: Ye Ting <ting.ye@intel.com>
(cherry picked from commit dce03c4)
makubacki pushed a commit to tianocore/edk2-crypto that referenced this pull request Dec 4, 2025
@makubacki
CryptoPkg/OpensslLib: Update OpenSSL version to 1.1.0g
8073f06 
Update the supported OpenSSL version to the latest 1.1.0g (02-Nov-2017).
The changes includes:
 - Re-generate the OpensslLib[crypto].inf using process_files.pl script
   to reflect the openssl source changes.
 - Update OpenSSL-HOWTO.txt
 - On Visual Studio Build: adding "/wd4819" to disable one addition build
   warning issue, which was already fixed in OpenSSL-HEAD
   openssl/openssl#4691.
 - On GCC Build: openssl-1.1.0g introduced one additional build warning:
    ...\openssl\crypto\asn1\x_int64.c:105:32: error: format '%ld' expects
        argument of type 'long int', but argument 3 has type 'int64_t
        {aka long long int}' [-Werror=format=]
    return BIO_printf(out, "%"BIO_PRI64"d\n", **(int64_t **)pval);
                                ^
    Adding "-Wno-error=format" to GCC build flag to suppress this warning,
    since we have no real printf usage in BaseCryptLib, and BIO_printf()
    was already wrappered as the dummy implementation in CryptoPkg.

Cc: Ye Ting <ting.ye@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Long Qin <qin.long@intel.com>
Reviewed-by: Ye Ting <ting.ye@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@levitte levitte levitte approved these changes

@t-j-h t-j-h t-j-h approved these changes

Assignees

No one assigned

Labels

approval: done This pull request has the required number of approvals branch: master Applies to master branch branch: 1.0.2 Applies to OpenSSL_1_0_2-stable branch (EOL)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@qloong @bernd-edlinger @levitte @t-j-h @mattcaswell