Add missing prototype for FIPS callback #4870
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcaswell
approved these changes
Dec 7, 2017
Member
|
Travis failure is unrelated (see #4866) |
|
FWIW: this solved my issue in #4864 |
levitte
approved these changes
Dec 7, 2017
|
I have tested this patch for all combinations of VC-WIN32/VC-WIN64A, vc9/vc11/vc14/vc15 and dll's/static libs with OpenSSL-Fips-2.0.16. 'passed all tests' in all 16 instances. |
Contributor
Author
|
Thanks for your effort, @Jan-E! |
Fixes openssl#2533 The call to FIPS_crypto_set_id_callback() was added in revision a43cfd7, but there is no prototype for it in <openssl/fips.h>. Signed-off-by: Dr. Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com>
015e9c6 to
4a8e333
Compare
Contributor
Author
|
Rebased without changes to fix the fatalerrtest and get some green lights from the build bots. |
Member
|
Pushed. Thanks. |
levitte
pushed a commit
that referenced
this pull request
Dec 8, 2017
Fixes #2533 The call to FIPS_crypto_set_id_callback() was added in revision a43cfd7, but there is no prototype for it in <openssl/fips.h>. Signed-off-by: Dr. Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #4870)
My pleasure. I gave all of you due credit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2533
The call to FIPS_crypto_set_id_callback() was added in revision a43cfd7, but there is no prototype for it in <openssl/fips.h>.