Fix fatalerrtest (1.0.2) #4866
Closed
Fix fatalerrtest (1.0.2) #4866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Confirmed that |
richsalz
approved these changes
Dec 7, 2017
levitte
approved these changes
Dec 7, 2017
levitte
reviewed
Dec 7, 2017
|
|
||
| /* SSL_read()/SSL_write should fail because of a previous fatal error */ | ||
| if ((len = SSL_read(sssl, buf, sizeof(buf - 1))) > 0) { | ||
| if ((len = SSL_read(sssl, buf, sizeof(buf) - 1)) > 0) { |
Member
There was a problem hiding this comment.
That one was particularly painful...
levitte
pushed a commit
that referenced
this pull request
Dec 7, 2017
Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #4866)
Contributor
|
I merged this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some variables are uninitialised on use in the event of an error condition. This issue doesn't seem to be present in the master/1.1.0 versions, so I'm not sure how that happened.
Also a misplaced -1 means the buffer size used for the SSL_read() call is the size of a char * not the size of the array.
Fixes #4865
Checklist