test/recipes/01-test_symbol_presence.t: check for duplicate symbols in static libs#20331
Closed
levitte wants to merge 3 commits intoopenssl:masterfrom
Closed
test/recipes/01-test_symbol_presence.t: check for duplicate symbols in static libs#20331levitte wants to merge 3 commits intoopenssl:masterfrom
levitte wants to merge 3 commits intoopenssl:masterfrom
Conversation
…n static libs This checks that all symbols are unique across all public static libraries. This includes a bit of refacftoring to avoid repeating code too much.
…mbols in static libs
Member
Author
|
Ping! I personally favor this over #20308 |
tmshort
reviewed
Feb 21, 2023
mattcaswell
reviewed
Feb 22, 2023
…mbols in static libs
mattcaswell
approved these changes
Feb 22, 2023
paulidale
approved these changes
Feb 22, 2023
Contributor
Pleased that you adopted (the essence of) the proposal I gave there, namely to use BTW, I took notice of the original PR just because you used (for good reasaon) the strong word 'brutally' in its title :) |
Collaborator
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
Contributor
|
Merged. |
openssl-machine
pushed a commit
that referenced
this pull request
Feb 23, 2023
…n static libs This checks that all symbols are unique across all public static libraries. This includes a bit of refacftoring to avoid repeating code too much. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #20331)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checks that all symbols are unique across all public static libraries.
This includes a bit of refacftoring to avoid repeating code too much.
This is an alternative for #20308