Github Action: brutally try to merge libcrypto and libssl#20308
Github Action: brutally try to merge libcrypto and libssl#20308levitte wants to merge 3 commits intoopenssl:masterfrom
Conversation
This build test does one thing only, it tries to brutally merge libcrypto.a and libssl.a, thus ensuring that there aren't any duplicate symbols between them. Fixes openssl#20304
tmshort
left a comment
There was a problem hiding this comment.
Too bad ar or libtool can't figure this out.
slontis
left a comment
There was a problem hiding this comment.
Maybe rename to duplicate_symbol_check.yml ?
Not sure why? Do you mean we should have one job per yaml file? I'm rather thinking that this file would collect other special cases... |
|
Yep - one per job. 'Special' doesn't mean much if I was looking for this particular check. |
That's note entirely true, but ok, fair enough |
|
Rename done |
|
Why not simply use something like this? |
|
I'm still good with the rename. |
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
Oh, that was actually smart... and actually, we have a test recipe that already plays with |
|
Closing, since #20331 is now merged |
This build test does one thing only, it tries to brutally merge libcrypto.a
and libssl.a, thus ensuring that there aren't any duplicate symbols between
them.
Fixes #20304