Skip to content

openssl-3.1#20290: Fixed typo in "config" man page#20311

Closed
blazmonster wants to merge 1 commit intoopenssl:openssl-3.1from
blazmonster:openssl-3.1#20290
Closed

openssl-3.1#20290: Fixed typo in "config" man page#20311
blazmonster wants to merge 1 commit intoopenssl:openssl-3.1from
blazmonster:openssl-3.1#20290

Conversation

@blazmonster
Copy link
Contributor

CLA: trivial

Checklist
  • documentation is added or updated

@beldmit beldmit added branch: master Applies to master branch approval: review pending This pull request needs review by a committer branch: 3.1 Applies to openssl-3.1 (EOL) cla: trivial One of the commits is marked as 'CLA: trivial' labels Feb 16, 2023
@beldmit
Copy link
Member

beldmit commented Feb 16, 2023

LGTM, agree trivial

Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with trivial.

@tmshort tmshort added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Feb 16, 2023
@tmshort
Copy link
Contributor

tmshort commented Feb 16, 2023

@beldmit, do you need to actually do the formal github approval?

Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beldmit
Copy link
Member

beldmit commented Feb 16, 2023

@tmshort sorry, forgot it. Thanks!

@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@paulidale
Copy link
Contributor

Merged, thanks for the fix.

@paulidale paulidale closed this Feb 19, 2023
openssl-machine pushed a commit that referenced this pull request Feb 19, 2023
CLA: trivial

Reviewed-by: Todd Short <todd.short@me.com>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #20311)

(cherry picked from commit 3da073c)
openssl-machine pushed a commit that referenced this pull request Feb 19, 2023
CLA: trivial

Reviewed-by: Todd Short <todd.short@me.com>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #20311)
@blazmonster blazmonster deleted the openssl-3.1#20290 branch April 3, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: done This pull request has the required number of approvals branch: master Applies to master branch branch: 3.1 Applies to openssl-3.1 (EOL) cla: trivial One of the commits is marked as 'CLA: trivial'

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants