[release-v1.16] Improve Go templates README #1319
Conversation
Signed-off-by: Matej Vašek <mvasek@redhat.com>
|
/override "style / Golang / Lint" |
|
@matejvasek: Overrode contexts on behalf of matejvasek: style / Golang / Lint DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release-v1.16 #1319 +/- ##
================================================
Coverage ? 63.51%
================================================
Files ? 131
Lines ? 15807
Branches ? 0
================================================
Hits ? 10040
Misses ? 4801
Partials ? 966
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-v1.17 |
|
@gauron99: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override Code Style / style / Golang / Lint (pull_request) |
|
@gauron99: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "Code Style / style / Golang / Lint (pull_request)" |
|
@gauron99: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8dc0b99
into
openshift-knative:release-v1.16
|
@gauron99: #1319 failed to apply on top of branch "release-v1.17": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
* openshift-knative/kn-plugin-func#1317 * openshift-knative/kn-plugin-func#1318 * openshift-knative/kn-plugin-func#1319 * openshift-knative/kn-plugin-func#1349 Signed-off-by: Matej Vašek <matejvasek@gmail.com>
README now does mention that the
GOPRIVATEenvironment variable should be set when using private repositories.