Skip to content

[release-v1.16] Fix detection of hostname resolution failure #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gauron99 merged 1 commit into from
Jul 16, 2025
Merged

[release-v1.16] Fix detection of hostname resolution failure #1318

gauron99 merged 1 commit into from
Jul 16, 2025

Conversation

@matejvasek
Copy link
Collaborator

@matejvasek matejvasek commented May 28, 2025 •
edited
Loading

Fixing a bug where host name resolution failure was detected as a different kind of error.
Because of that on cluster dialer did not kick in and the operation failed immediately, instead of trying to tunneling connection via cluster.

@matejvasek
Fix detection of hostname resolution failure
8b7739d 
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@openshift-ci openshift-ci bot requested review from dsimansk and jrangelramos May 28, 2025 14:03
@matejvasek
Copy link
Collaborator Author

matejvasek commented May 28, 2025

/override "style / Golang / Lint"

@openshift-ci
Copy link

openshift-ci bot commented May 28, 2025

@matejvasek: Overrode contexts on behalf of matejvasek: style / Golang / Lint

Details

In response to this:

/override "style / Golang / Lint"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matejvasek matejvasek requested a review from lkingland May 28, 2025 15:17
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-v1.16@40ce764). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-v1.16    #1318   +/-   ##
================================================
  Coverage                 ?   63.54%           
================================================
  Files                    ?      131           
  Lines                    ?    15810           
  Branches                 ?        0           
================================================
  Hits                     ?    10046           
  Misses                   ?     4799           
  Partials                 ?      965
Flag Coverage Δ
e2e-test 35.26% <0.00%> (?)
e2e-test-runtime-go 25.51% <0.00%> (?)
e2e-test-runtime-node 24.87% <0.00%> (?)
e2e-test-runtime-quarkus 24.96% <0.00%> (?)
e2e-test-runtime-rust 24.44% <0.00%> (?)
e2e-test-runtime-springboot 24.51% <0.00%> (?)
e2e-test-runtime-typescript 24.96% <0.00%> (?)
integration-tests 50.66% <0.00%> (?)
unit-tests 49.79% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gauron99
gauron99 approved these changes Jul 16, 2025
View reviewed changes
Copy link

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Jul 16, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jul 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gauron99
Copy link

gauron99 commented Jul 16, 2025

/cherry-pick release-v1.17

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jul 16, 2025

@gauron99: once the present PR merges, I will cherry-pick it on top of release-v1.17 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gauron99 gauron99 merged commit 8470d19 into openshift-knative:release-v1.16 Jul 16, 2025
42 of 47 checks passed
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jul 16, 2025

@gauron99: #1318 failed to apply on top of branch "release-v1.17":

Applying: Fix detection of hostname resolution failure
Using index info to reconstruct a base tree...
M	pkg/docker/pusher.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/docker/pusher.go
CONFLICT (content): Merge conflict in pkg/docker/pusher.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Fix detection of hostname resolution failure
Details

In response to this:

/cherry-pick release-v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matejvasek matejvasek mentioned this pull request Aug 20, 2025
Merged
openshift-merge-bot bot pushed a commit to openshift-knative/client that referenced this pull request Aug 20, 2025
@matejvasek
[release-v1.16] Update knative.dev/func dep (#775)
cc91ac2 
* openshift-knative/kn-plugin-func#1317
* openshift-knative/kn-plugin-func#1318
* openshift-knative/kn-plugin-func#1319
* openshift-knative/kn-plugin-func#1349

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gauron99 gauron99 gauron99 approved these changes

@dsimansk dsimansk Awaiting requested review from dsimansk

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

@lkingland lkingland Awaiting requested review from lkingland

Assignees

@gauron99 gauron99

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matejvasek @codecov-commenter @gauron99 @openshift-cherrypick-robot