Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

Conversation

@mgencur
Copy link

@mgencur mgencur commented Dec 4, 2018

Changes that are necessary after merging openshift/release#2209

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 4, 2018
@mgencur
Copy link
Author

mgencur commented Dec 5, 2018

/retest

1 similar comment
@mgencur
Copy link
Author

mgencur commented Dec 5, 2018

/retest

@openshift-ci-robot
Copy link

@mgencur: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e 133564d link /test e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mgencur
Copy link
Author

mgencur commented Dec 5, 2018

So now the failing test is TestAutoscaleUpDownUp, and previously it was TestBuildAndServe. These two fail randomly on this branch. I've also seen that these two have been updated recently on master branch where we didn't see them failing.

@alanfx
Copy link

alanfx commented Dec 14, 2018

Thanks a lot, @mgencur. The changes look good and the test failures seem unrelated.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanfx, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alanfx alanfx merged commit 21c50f0 into openshift:release-0.2 Dec 14, 2018
openshift-cherrypick-robot added a commit to openshift-cherrypick-robot/knative-serving that referenced this pull request Nov 24, 2022
…hift#1283) (openshift#19)

* Run queue proxy with restricted profile (knative#13376)

* allow user workloads to run with restricted profile

* only change queue proxy

* remove seccomp

Co-authored-by: Stavros Kontopoulos <skontopo@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants