Prefix knative images with knative- #2209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/hold |
* Use knative-serving-, knative-build-, knative-eventing- prefixes to prevent naming colision across those projects. (e.g. all three repos have "controller" image so we need to differentiate them) * Even though now we publish the images to "knative" image stream, later we might need to publish them to origin-v* and so we also include the knative- prefix
100e096 to
0dd9f82
Compare
Contributor
|
Sure, naming is fine |
Contributor
Author
|
Thanks! |
Contributor
|
/hold cancel |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgencur, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
@mgencur: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This was referenced Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevent naming colision across those projects. (e.g. all three repos
have "controller" image so we need to differentiate them)
we might need to publish them to origin-v* and so we also include the
knative- prefix.