This repository was archived by the owner on Dec 1, 2022. It is now read-only.
Pull all images from the OpenShift internal registry #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change tags all CI-built images into the OpenShift internal registry in the format expected by Knative - ie `controller:latest` versus `stable:controller`. And it updates all image references to point to the internal registry instead of `registry.svc.ci.openshift.org`. I'm not sure this will actually work, but let's find out.
When replacing imagePath first, if the configured docker registry happens to contain the string "default" then the namespace replacement ends up munging the registry value as well. Switching the order prevents that problem.
|
Interesting solution for the last problem. I issued this some time ago: knative#2409 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bbrowning, mgencur The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
markusthoemmes
pushed a commit
that referenced
this pull request
Apr 3, 2019
Pull all images from the OpenShift internal registry
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/knative-serving
that referenced
this pull request
Nov 24, 2022
…hift#1283) (openshift#13) * Run queue proxy with restricted profile (knative#13376) * allow user workloads to run with restricted profile * only change queue proxy * remove seccomp
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change tags all CI-built images into the OpenShift internal
registry in the format expected by Knative - ie
controller:latestversus
stable:controller. And it updates all image references topoint to the internal registry instead of
registry.svc.ci.openshift.org.I'm not sure this will actually work, but let's find out.