Prevent replacing "default" other than in namespace #2409
Conversation
|
@adrcunha hey Adriano, what do you think about this PR? I'm curious if this is likely to be accepted and apply the change in our own fork too before we rebase to latest upstream. Thanks. |
|
/assign @mattmoor jessiezcc |
|
Are the folks working on this atop OpenShift going to the weekly productivity WG meetings? Perhaps this is a good item for that agenda? |
|
/lgtm I think this is fine for fixing the issue explained in this PR, thus I don't see why this would require a discussion in the productivity WG. Holding for any further comment from Matt though. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha, mgencur The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I believe @mattmoor was referring to some issues that were linked to this PR by Github? I believe the issue being resolved in this PR doesn't need more discussion. |
|
I'm not generally thrilled by the idea of using /hold cancel |
|
/retest |
Fixes the following problem:
The image path is obtained by calling
test.ImagePath("helloworld"). The path is replaced in the yaml file including Coufiguration and Route. Now if that resulting path includes word "default" it will be replaced again by "serving-namespace" accidentally.We need to make sure the image path is obtained solely via
test.ImagePath("helloworld"). This path includes the registry address. We need to make sure it is not changed afterwards. We only want to change the "namespace" declaration.