Skip to content

NO-JIRA: Remove ocs-install-tour#1003

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
lance5890:rm_ocs-install-tour
Jul 7, 2025
Merged

NO-JIRA: Remove ocs-install-tour#1003
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
lance5890:rm_ocs-install-tour

Conversation

@lance5890

@lance5890 lance5890 commented Jun 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

kind of post-cleanup of #559
address openshift/cluster-version-operator#1207

this yaml has beed removed from 4.9, which is out of suppuort now, we should remove this yaml in the newest version(4.20)

@openshift-ci openshift-ci Bot requested review from TheRealJon and vikram-raj June 24, 2025 10:28
@lance5890

lance5890 commented Jun 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

/cc @jhadvig

@openshift-ci

openshift-ci Bot commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

Hi @lance5890. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 24, 2025
@openshift-ci openshift-ci Bot requested a review from vbnrh June 24, 2025 10:28
lance5890
lance5890 commented Jun 25, 2025
View reviewed changes
Comment thread quickstarts/ocs-install-tour-quickstart.yaml
@vikram-raj

vikram-raj commented Jun 26, 2025

Copy link
Copy Markdown
Member

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 26, 2025
@lance5890

lance5890 commented Jun 26, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

@lance5890 lance5890 changed the title NO_ISSUE: remove ocs-install-tour NO_ISSUE: Remove ocs-install-tour Jun 26, 2025
@lance5890 lance5890 changed the title NO_ISSUE: Remove ocs-install-tour NO-ISSUE: Remove ocs-install-tour Jun 26, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 26, 2025
@openshift-ci-robot

openshift-ci-robot commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

@lance5890: This pull request explicitly references no jira issue.

Details

In response to this:

kind of post-cleanup of #559

this yaml has beed removed from 4.9, which is out of suppuort now, we should remove this yaml in the newest version(4.20)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

This was referenced Jul 1, 2025
Closed
Closed
@lance5890

lance5890 commented Jul 1, 2025

Copy link
Copy Markdown
Contributor Author

/ok-to-test

should we move forward ?

@lance5890 lance5890 changed the title NO-ISSUE: Remove ocs-install-tour NO-JIRA: Remove ocs-install-tour Jul 1, 2025
@spadgett

spadgett commented Jul 1, 2025

Copy link
Copy Markdown
Member

/assign @bipuladh

@bipuladh

bipuladh commented Jul 3, 2025

Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2025
spadgett
spadgett approved these changes Jul 3, 2025
View reviewed changes

@spadgett spadgett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/retest

@openshift-ci

openshift-ci Bot commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, lance5890, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2025
@lance5890

lance5890 commented Jul 3, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@jhadvig jhadvig added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jul 7, 2025
@openshift-ci

openshift-ci Bot commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

@lance5890: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit c9eb614 into openshift:main Jul 7, 2025
12 checks passed
@openshift-bot

openshift-bot commented Jul 8, 2025

Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console-operator
This PR has been included in build openshift-enterprise-console-operator-container-v4.20.0-202507072312.p0.gc9eb614.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

@vikram-raj vikram-raj Awaiting requested review from vikram-raj

@vbnrh vbnrh Awaiting requested review from vbnrh

Assignees

@bipuladh bipuladh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@lance5890 @vikram-raj @openshift-ci-robot @spadgett @bipuladh @openshift-bot @jhadvig