Skip to content

Adds ODF install tour#559

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
vbnrh:install-odf-quickstart
Jul 21, 2021
Merged

Adds ODF install tour#559
openshift-merge-robot merged 1 commit into
openshift:masterfrom
vbnrh:install-odf-quickstart

Conversation

@vbnrh

@vbnrh vbnrh commented Jun 24, 2021

Copy link
Copy Markdown
Contributor

For 4.9 release, OCS operator will be replaced with the ODF at a higher level. Hence we would want to make sure that new install quickstart accurately represent the workflows for ODF operator.

This commit adds quickstart for installing the ODF operator and setting up the storage cluster.

Signed-off-by: Vineet Badrinath vbadrina@redhat.com

@openshift-ci openshift-ci Bot requested review from jhadvig and spadgett June 24, 2021 10:47
Comment thread quickstarts/install-odf.yaml
@spadgett

Copy link
Copy Markdown
Member

@openshift/quickstart-ux-content

@serenamarie125 serenamarie125 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a few changes and have some questions. Thanks for pinging me for a review!

I'd assume this should be called odf-install-tour ?

Comment thread quickstarts/install-odf.yaml
Comment thread quickstarts/install-odf.yaml Outdated
Comment thread quickstarts/install-odf.yaml
@spadgett

spadgett commented Jul 9, 2021

Copy link
Copy Markdown
Member

If we want to rename the resource, I believe we can now add a release.openshift.io/delete: "true" annotation to the old manifest so it's removed. We'd need to test that it's implemented. See https://github.com/openshift/enhancements/blob/ce4d303db807622687159eb9d3248285a003fabb/enhancements/update/object-removal-manifest-annotation.md

@jhadvig jhadvig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I dont think that we can just rename the CVO managed resources. As @spadgett mentioned we should rather add the release.openshift.io/delete: "true" annotation to the old manifest so it's removed and create the new ODF install tour.

Signed-off-by: Vineet Badrinath <vbadrina@redhat.com>
@vbnrh vbnrh force-pushed the install-odf-quickstart branch from c9cb711 to 389ab54 Compare July 21, 2021 08:11
@vbnrh

vbnrh commented Jul 21, 2021

Copy link
Copy Markdown
Contributor Author

@jhadvig @spadgett I have added the annotation to the older manifest and updated the PR.

Please take a look

@vbnrh vbnrh requested review from jhadvig and spadgett July 21, 2021 12:17
@vbnrh

vbnrh commented Jul 21, 2021

Copy link
Copy Markdown
Contributor Author

/test e2e-aws-operator

@spadgett spadgett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2021
@openshift-ci

openshift-ci Bot commented Jul 21, 2021

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, vbnrh, yuvalgalanti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2021
@openshift-merge-robot openshift-merge-robot merged commit 26c292f into openshift:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants