Skip to content

NO-JIRA: Remove ibm-cloud-managed-cleanup yaml#586

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
lance5890:rm_ibm-cloud-managed-cleaup
Oct 29, 2025
Merged

NO-JIRA: Remove ibm-cloud-managed-cleanup yaml#586
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
lance5890:rm_ibm-cloud-managed-cleaup

Conversation

@lance5890

@lance5890 lance5890 commented Jun 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
  1. these yamls has already been deleted in no CredentialsRequests in ibm-cloud-managed #253, cvo will skip these yamls in newer version
  2. I notice that some PRs still change these yamls, but that should be useless,such as OCPBUGS-29573: Apply hypershift cluster-profile for ibm-cloud-managed #458
  3. address Remove unused yaml in cvo to speed up reconciliation cluster-version-operator#1207

so maybe rm the redundant yaml should be a good option

@openshift-ci openshift-ci Bot requested review from jsafrane and tsmetana June 18, 2025 03:16
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 18, 2025
@openshift-ci

openshift-ci Bot commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

Hi @lance5890. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lance5890
lance5890 commented Jun 19, 2025
View reviewed changes
Comment thread manifests/ibm-cloud-managed-cleanup.yaml
capability.openshift.io/name: CloudCredential
include.release.openshift.io/hypershift: "true"
include.release.openshift.io/ibm-cloud-managed: "true"
release.openshift.io/delete: "true"

@lance5890 lance5890 Jun 19, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cvo will skip these yamls with "release.openshift.io/delete" annotation

and this only works when upgrade from older version

This was referenced Jul 1, 2025
Closed
Closed
@lance5890 lance5890 changed the title NO_JIRA: rm ibm-cloud-managed-cleanup yaml NO_JIRA: Removs ibm-cloud-managed-cleanup yaml Jul 2, 2025
@lance5890 lance5890 changed the title NO_JIRA: Removs ibm-cloud-managed-cleanup yaml NO_JIRA: Remove ibm-cloud-managed-cleanup yaml Jul 2, 2025
@Phaow

Phaow commented Aug 28, 2025

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 28, 2025
@lance5890

lance5890 commented Sep 13, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@jsafrane

jsafrane commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2025
@openshift-ci

openshift-ci Bot commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, lance5890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2025
@jsafrane jsafrane changed the title NO_JIRA: Remove ibm-cloud-managed-cleanup yaml NO-JIRA: Remove ibm-cloud-managed-cleanup yaml Sep 25, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 25, 2025
@openshift-ci-robot

openshift-ci-robot commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

@lance5890: This pull request explicitly references no jira issue.

Details

In response to this:

  1. these yamls has already been deleted in no CredentialsRequests in ibm-cloud-managed #253, cvo will skip these yamls in newer version
  2. I notice that some PRs still change these yamls, but that should be useless,such as OCPBUGS-29573: Apply hypershift cluster-profile for ibm-cloud-managed #458
  3. address Remove unused yaml in cvo to speed up reconciliation cluster-version-operator#1207

so maybe rm the redundant yaml should be a good option

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfajmon dfajmon mentioned this pull request Oct 13, 2025
Merged
@chao007

chao007 commented Oct 28, 2025

Copy link
Copy Markdown

/test e2e-openstack

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2025
@lance5890
rm ibm-cloud-managed-cleanup yaml
e095113 
Signed-off-by: lan.tian <lance5890@163.com>
@lance5890 lance5890 force-pushed the rm_ibm-cloud-managed-cleaup branch from 48776f5 to e095113 Compare October 28, 2025 08:37
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2025
@lance5890

lance5890 commented Oct 29, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

@openshift-ci

openshift-ci Bot commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

@lance5890: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-parallel 48776f5 link false /test e2e-openstack-parallel
ci/prow/e2e-openstack 48776f5 link false /test e2e-openstack
ci/prow/okd-scos-e2e-aws-ovn e095113 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@chao007

chao007 commented Oct 29, 2025

Copy link
Copy Markdown

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 29, 2025
@openshift-ci-robot

openshift-ci-robot commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

@chao007: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Phaow

Phaow commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit 2647d9e into openshift:main Oct 29, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsafrane jsafrane Awaiting requested review from jsafrane

@tsmetana tsmetana Awaiting requested review from tsmetana

Assignees

@jsafrane jsafrane

@chao007 chao007

@duanwei33 duanwei33

@Phaow Phaow

@radeore radeore

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@lance5890 @Phaow @jsafrane @openshift-ci-robot @chao007 @openshift-merge-robot @duanwei33 @radeore