Skip to content

OCPBUGS-29573: Apply hypershift cluster-profile for ibm-cloud-managed#458

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:masterfrom
openshift-art-build-bot:art-8431
Feb 22, 2024
Merged

OCPBUGS-29573: Apply hypershift cluster-profile for ibm-cloud-managed#458
openshift-merge-bot[bot] merged 2 commits into
openshift:masterfrom
openshift-art-build-bot:art-8431

Conversation

@openshift-art-build-bot

Copy link
Copy Markdown
Contributor

Since HyperShift / Hosted Control Plane have adopted include.release.openshift.io/ibm-cloud-managed, to tailor the resources of clusters running in the ROKS IBM environment, the include.release.openshift.io/hypershift addition will allow Hypershift to express different profile choices than ROKS

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 15, 2024
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@openshift-art-build-bot: This pull request references Jira Issue OCPBUGS-29573, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Since HyperShift / Hosted Control Plane have adopted include.release.openshift.io/ibm-cloud-managed, to tailor the resources of clusters running in the ROKS IBM environment, the include.release.openshift.io/hypershift addition will allow Hypershift to express different profile choices than ROKS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ashwindasr

Copy link
Copy Markdown

If any other file needs to be updated to support this change, please let me know.

@openshift-ci openshift-ci Bot requested review from gnufied and mpatlasov February 15, 2024 21:43
@jsafrane

Copy link
Copy Markdown
Contributor

@ashwindasr you must update https://github.com/openshift/cluster-storage-operator/blob/master/profile-patches/ibm-cloud-managed/10_deployment.yaml-patch too.

And make update.

add hypershift annotation
@openshift-ci

openshift-ci Bot commented Feb 21, 2024

Copy link
Copy Markdown
Contributor

@openshift-art-build-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-shared-resources f6c7f2b link false /test e2e-aws-shared-resources
ci/prow/e2e-ibmcloud-csi f6c7f2b link false /test e2e-ibmcloud-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2024
@openshift-ci

openshift-ci Bot commented Feb 22, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, openshift-art-build-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2024
@openshift-merge-bot openshift-merge-bot Bot merged commit 88ab658 into openshift:master Feb 22, 2024
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@openshift-art-build-bot: Jira Issue OCPBUGS-29573: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29573 has been moved to the MODIFIED state.

Details

In response to this:

Since HyperShift / Hosted Control Plane have adopted include.release.openshift.io/ibm-cloud-managed, to tailor the resources of clusters running in the ROKS IBM environment, the include.release.openshift.io/hypershift addition will allow Hypershift to express different profile choices than ROKS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot

Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-storage-operator-container-v4.16.0-202402221310.p0.g88ab658.assembly.stream.el9 for distgit cluster-storage-operator.
All builds following this will include this PR.

@openshift-merge-robot

Copy link
Copy Markdown
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-02-22-180402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants