Skip to content

NO-JIRA: Remove manifest for validating-webhook-configuration#324

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
lance5890:rm_cluster-api-webhook
Jun 26, 2025
Merged

NO-JIRA: Remove manifest for validating-webhook-configuration#324
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
lance5890:rm_cluster-api-webhook

Conversation

@lance5890

@lance5890 lance5890 commented Jun 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

kind of post-cleanup of #145

reduce the unused number of yamls, cvo will not reconcile this yaml

it only works when upgrade from 4.15, can be removed in the newest version(4.20)

address openshift/cluster-version-operator#1207

@lance5890

lance5890 commented Jun 25, 2025

Copy link
Copy Markdown
Contributor Author

/cc @wking

@openshift-ci openshift-ci Bot requested a review from wking June 25, 2025 07:30
@lance5890

lance5890 commented Jun 25, 2025

Copy link
Copy Markdown
Contributor Author

/cc @JoelSpeed

@openshift-ci openshift-ci Bot requested review from JoelSpeed, RadekManak and nrb June 25, 2025 07:30
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 25, 2025
@openshift-ci

openshift-ci Bot commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

Hi @lance5890. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@JoelSpeed

JoelSpeed commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2025
@openshift-ci

openshift-ci Bot commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2025
@JoelSpeed

JoelSpeed commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 25, 2025
@lance5890

lance5890 commented Jun 25, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

2 similar comments
@lance5890

lance5890 commented Jun 25, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

@lance5890

lance5890 commented Jun 25, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

lance5890
lance5890 commented Jun 25, 2025
View reviewed changes
Comment thread manifests/0000_30_cluster-api_10_webhooks.yaml
@lance5890

lance5890 commented Jun 26, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

@openshift-ci

openshift-ci Bot commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

@lance5890: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal3-capi-techpreview d61abba link false /test e2e-metal3-capi-techpreview
ci/prow/okd-scos-e2e-aws-ovn d61abba link false /test okd-scos-e2e-aws-ovn
ci/prow/regression-clusterinfra-cucushift-rehearse-capi-aws-ipi d61abba link false /test regression-clusterinfra-cucushift-rehearse-capi-aws-ipi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lance5890 lance5890 changed the title NO-JIRA：remove manifest for validating-webhook-configuration NO-JIRA: Remove manifest for validating-webhook-configuration Jun 26, 2025
@openshift-ci-robot

openshift-ci-robot commented Jun 26, 2025

Copy link
Copy Markdown

@lance5890: This pull request explicitly references no jira issue.

Details

In response to this:

kind of post-cleanup of #145

reduce the unused number of yamls, cvo will not reconcile this yaml

it only works when upgrade from 4.15, can be removed in the newest version(4.20)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 26, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit d3c592d into openshift:main Jun 26, 2025
21 of 24 checks passed
@openshift-bot

openshift-bot commented Jun 26, 2025

Copy link
Copy Markdown

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-capi-operator
This PR has been included in build ose-cluster-capi-operator-container-v4.20.0-202506260747.p0.gd3c592d.assembly.stream.el9.
All builds following this will include this PR.

This was referenced Jul 1, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wking wking Awaiting requested review from wking

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@nrb nrb Awaiting requested review from nrb

@RadekManak RadekManak Awaiting requested review from RadekManak

Assignees

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lance5890 @JoelSpeed @openshift-ci-robot @openshift-bot