OCPBUGS-23467: manifests/0000_30_cluster-api_10_webhooks: Deletion manifest for validating-webhook-configuration#145
Conversation
…dating-webhook-configuration The resource was renamed to cluster-capi-operator in 1096d5c (manifests: rename validatingwebhookconfiguration to a more meaningful name, 2023-10-12, openshift#132), and that's a much more specific name for the cluster-scoped resource. However, clusters upating from 4.15.0-ec.1 with the old name should not have two similar-but-not-quite-matching versions of the webhook configuration, or updates can stick with cluster-api ClusterOperator going Degraded=True on SyncingFailed with [1]: Failed to resync for operator: 4.15.0-ec.2 because &{%!e(string=unable to reconcile CoreProvider: unable to create or update CoreProvider: Internal error occurred: failed calling webhook "vcoreprovider.operator.cluster.x-k8s.io": failed to call webhook: the server could not find the requested resource)} This commit adds a deletion manifest [2] to ask the cluster-version operator to remove the resource, to avoid leaking the old resource into new clusters. [1]: https://issues.redhat.com/browse/OCPBUGS-23467 [2]: https://github.com/openshift/enhancements/blob/8a11b7085c69b078690d50958f541d2a817d85df/dev-guide/cluster-version-operator/dev/object-deletion.md
|
@wking: This pull request references Jira Issue OCPBUGS-23467, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@wking: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
@wking: Jira Issue OCPBUGS-23467: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-23467 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-capi-operator-container-v4.15.0-202311211133.p0.g17627ff.assembly.stream for distgit ose-cluster-capi-operator. |
The resource was renamed to
cluster-capi-operatorin 1096d5c (#132), and that's a much more specific name for the cluster-scoped resource. However, clusters upating from 4.15.0-ec.1 with the old name should not have two similar-but-not-quite-matching versions of the webhook configuration, or updates can stick withcluster-apiClusterOperator goingDegraded=TrueonSyncingFailedwith:This commit adds a deletion manifest to ask the cluster-version operator to remove the resource, to avoid leaking the old resource into new clusters.