@chiragkyal: This pull request references CFE-1133 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

/test images

/retest-required

/test all

@chiragkyal: This pull request references CFE-1133 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

/retest-required

/retest

/assign @alebedev87

/retest

/retest-required

/retest-required

/test e2e-aws-proxy-operator

/test e2e-aws-rosa-operator

@alebedev87 It Looks like the e2e-aws-rosa-operator is failing with something new, which seems unrelated to this PR. Any idea why it's complaining ?

An error occurred (WAFNonexistentItemException) when calling the GetWebACL operation: AWS WAF couldn’t perform the operation because your resource doesn’t exist.
{"component":"entrypoint","error":"wrapped process failed: exit status 254","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2024-12-12T07:24:42Z"}

openshift/release#59728 could fix the e2e problem

@chiragkyal : Thanks a lot for your work!

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

/retest

/label px-approved

@chiragkyal: all tests passed!

Full PR test history. Your PR dashboard.

@chiragkyal I'm doing pre-merge test, after updating the resourceTags in infrastructure status, I observed that the controller pod is recreated, it that expected behavior?

aws-load-balancer-controller-cluster-6dd8859687-tzrpv             1/1     Running     0          2s
aws-load-balancer-controller-cluster-8b6c677cc-sz499              0/1     Completed   0          26m

And another finding is: looks it doesn't update the alb.ingress.kubernetes.io/tags annotation (refer to https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.2/guide/ingress/annotations/#resource-tags), it that expected?
cc @alebedev87

Hey, Yeah this is an expected behaviour because updating tags on infrastructure status will change the --default-tags container argument of the controller, necessitating pod recreation.

And another finding is: looks it doesn't update the alb.ingress.kubernetes.io/tags annotation (refer to https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.2/guide/ingress/annotations/#resource-tags), it that expected?

We're feeding the infrastructure tags directly into the --default-tags container arguments and not using alb.ingress.kubernetes.io/tags annotation. So, the annotation not getting updated in the event of updating infrastructure tags is also an expected behaviour. It's similar to what happens if we update the AdditionalResourceTags field.

Users may wish to use this annotation if they want to add more tags.

Thank you @chiragkyal and @alebedev87 for the detailed explanations.

I tested this PR and it looks good, after configuring the tags we got

$ aws elbv2 describe-tags --resource-arns "arn:aws:elasticloadbalancing:us-west-1:******:loadbalancer/app/k8s-hongli-ingresst-75f3b8f32d/1be0df7a277bdeab" --output yaml
TagDescriptions:
- ResourceArn: arn:aws:elasticloadbalancing:us-west-1:******:loadbalancer/app/k8s-hongli-ingresst-75f3b8f32d/1be0df7a277bdeab
  Tags:
  - Key: albc                                    <<<--- tags from AWSLoadBalancerController.spec
    Value: albc-tags
  - Key: ingress.k8s.aws/stack
    Value: hongli/ingress-test
  - Key: Owner                                    <<<--- tags from infrastructure.status
    Value: infra-tags
  - Key: ingress.k8s.aws/resource
    Value: LoadBalancer
  - Key: elbv2.k8s.aws/cluster
    Value: ci-ln-22g21zb-76ef8-mf6mh

note: similar tags for targetgroup, listener and listener-rule 

/label docs-approved

/label qe-approved

@chiragkyal: This pull request references CFE-1133 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.