Skip to content

aws-load-balancer: pre-install-rosa - create unique WAF ACLs#59728

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
alebedev87:albo-unique-waf
Dec 13, 2024
Merged

aws-load-balancer: pre-install-rosa - create unique WAF ACLs#59728
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
alebedev87:albo-unique-waf

Conversation

@alebedev87
Copy link
Copy Markdown
Contributor

@alebedev87 alebedev87 commented Dec 10, 2024

This PR tries to avoid sharing WAF ACLs between different PRs.

@alebedev87 alebedev87 changed the title aws-load-balancer: pre-install-rosa - create unique WAF ALC aws-load-balancer: pre-install-rosa - create unique WAF ACLs Dec 10, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2024
@DennisPeriquet
Copy link
Copy Markdown
Contributor

DennisPeriquet commented Dec 10, 2024

/hold
/lgtm

The change makes sense. Unhold when ready to merge.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2024
@alebedev87 alebedev87 mentioned this pull request Dec 10, 2024
Merged
@alebedev87
Copy link
Copy Markdown
Contributor Author

alebedev87 commented Dec 10, 2024

/pj-rehearse pull-ci-openshift-aws-load-balancer-operator-main-e2e-aws-rosa-operator

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Dec 10, 2024

@alebedev87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2024
@alebedev87
Copy link
Copy Markdown
Contributor Author

alebedev87 commented Dec 11, 2024

The classic WAF does not allow non alphanumeric characters in the name.

@alebedev87
Copy link
Copy Markdown
Contributor Author

alebedev87 commented Dec 11, 2024

/pj-rehearse pull-ci-openshift-aws-load-balancer-operator-main-e2e-aws-rosa-operator

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Dec 11, 2024

@alebedev87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@alebedev87
Copy link
Copy Markdown
Contributor Author

alebedev87 commented Dec 11, 2024

/pj-rehearse pull-ci-openshift-aws-load-balancer-operator-main-e2e-aws-rosa-operator

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Dec 11, 2024

@alebedev87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@alebedev87
Copy link
Copy Markdown
Contributor Author

alebedev87 commented Dec 11, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2024
@DennisPeriquet
Copy link
Copy Markdown
Contributor

DennisPeriquet commented Dec 11, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2024
@alebedev87
Copy link
Copy Markdown
Contributor Author

alebedev87 commented Dec 11, 2024

/pj-rehearse pull-ci-openshift-aws-load-balancer-operator-main-e2e-aws-rosa-operator

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Dec 11, 2024

@alebedev87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@alebedev87
Copy link
Copy Markdown
Contributor Author

alebedev87 commented Dec 11, 2024

/pj-rehearse pull-ci-openshift-aws-load-balancer-operator-main-e2e-aws-rosa-operator

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Dec 11, 2024

@alebedev87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@chiragkyal chiragkyal mentioned this pull request Dec 12, 2024
Merged
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2024
@alebedev87
Copy link
Copy Markdown
Contributor Author

alebedev87 commented Dec 12, 2024

/pj-rehearse pull-ci-openshift-aws-load-balancer-operator-main-e2e-aws-rosa-operator

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Dec 12, 2024

@alebedev87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Dec 12, 2024

[REHEARSALNOTIFIER]
@alebedev87: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-aws-load-balancer-operator-main-e2e-aws-rosa-operator openshift/aws-load-balancer-operator presubmit Registry content changed
pull-ci-openshift-aws-load-balancer-operator-release-1.1-e2e-aws-rosa-operator openshift/aws-load-balancer-operator presubmit Registry content changed
pull-ci-openshift-aws-load-balancer-operator-release-1.0-e2e-aws-rosa-operator openshift/aws-load-balancer-operator presubmit Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@alebedev87
Copy link
Copy Markdown
Contributor Author

alebedev87 commented Dec 12, 2024

/pj-rehearse pull-ci-openshift-aws-load-balancer-operator-main-e2e-aws-rosa-operator

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Dec 12, 2024

@alebedev87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@alebedev87
Copy link
Copy Markdown
Contributor Author

alebedev87 commented Dec 12, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Dec 12, 2024

@alebedev87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 12, 2024
@chiragkyal
Copy link
Copy Markdown
Member

chiragkyal commented Dec 13, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, chiragkyal, DennisPeriquet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Dec 13, 2024

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 6feeeb6 into openshift:master Dec 13, 2024
yingzhanredhat pushed a commit to yingzhanredhat/release that referenced this pull request Dec 18, 2024
@alebedev87 @yingzhanredhat
aws-load-balancer: pre-install-rosa - create unique WAF ACLs (openshi…
08dea0c 
…ft#59728)
yingzhanredhat pushed a commit to yingzhanredhat/release that referenced this pull request Dec 24, 2024
@alebedev87 @yingzhanredhat
aws-load-balancer: pre-install-rosa - create unique WAF ACLs (openshi…
848cb24 
…ft#59728)
krishvoor pushed a commit to krishvoor/release that referenced this pull request Jan 29, 2025
@alebedev87 @krishvoor
aws-load-balancer: pre-install-rosa - create unique WAF ACLs (openshi…
39d47e0 
…ft#59728)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DennisPeriquet DennisPeriquet Awaiting requested review from DennisPeriquet

@stbenjam stbenjam Awaiting requested review from stbenjam

Assignees

@chiragkyal chiragkyal

@DennisPeriquet DennisPeriquet

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alebedev87 @DennisPeriquet @openshift-ci-robot @chiragkyal