Migrate workbench to OpenSearch Dashboards by davidcui1225 · Pull Request #6 · opensearch-project/sql

davidcui1225 · 2021-04-13T23:26:07Z

Issue #, if available:
N/A
Description of changes:

Migrate workbench to OpenSearch Dashboards
bump version to 1.15

TODO: Update GitHub workflows, get feedback on changes needed in tslint.yaml with Elasticsearch BV license statement.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

.github/workflows/sql-workbench-test-and-build-workflow.yml

dblock · 2021-04-14T00:05:28Z

.github/workflows/sql-workbench-test-and-build-workflow.yml

          repository: elastic/kibana
          ref: v7.10.2
-          path: sql/kibana
+          path: sql/OpenSearch-Dashboards


I think paths should remain lowercase. + below many

Even though the OpenSearch-Dashboards repo has the upper case?

You're right. In hindsight maybe we should have made repo names lowercase, but YOLO.

workbench/.cypress/integration/ui.spec.js

workbench/README.md

workbench/opensearch_dashboards.json

workbench/public/components/app.tsx

dblock · 2021-04-14T00:10:19Z

workbench/server/routes/translate.ts

      },
    },
-    async (context, request, response): Promise<IKibanaResponse<any | ResponseError>> => {
+    async (context, request, response): Promise<IOpenSearchDashboardsResponse<any | ResponseError>> => {


I think this becomes IDashboardsResponse, if it's in this repo.

I think it's IOpenSearchDashboardsResponse based on

/** * A response data object, expected to returned as a result of {@link RequestHandler} execution * @public */ export interface IOpenSearchDashboardsResponse< T extends HttpResponsePayload | ResponseError = any > { readonly status: number; readonly payload?: T; readonly options: HttpResponseOptions; }

From the OpenSearch-Dashboards source code

dblock · 2021-04-14T00:11:05Z

workbench/server/services/utils/constants.ts

 export const DEFAULT_HEADERS = {
  'Content-Type': 'application/json',
  Accept: 'application/json',
-  'User-Agent': 'Kibana',


I don't know the context for this, but if we were returning a certain UA header we probably want to continue returning one.

Should I just change it to 'User-Agent': 'OpenSearch Dashboards' then?

AFAIK spaces in the user agent strings are considered separators according to the HTTP spec, so this would need to be OpenSearch-Dashboards.

…s-AOS-202-CAST Dialect: Added CAST to convert to int and string as of AOS-202

…pensearch-project#1181) * Allow quoted literals only in `DESCRIBE` and `SHOW` clauses. Tests. Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com> * Fix doctest after rebase. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Fix doctest after rebase. - Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Update syntax section. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Creation and updating 2.x branch (opensearch-project#6) * Create the 2.x branch * Add workflow_dispatch: to github CLI Signed-off-by: YANGDB <yang.db.dev@gmail.com>

* remove sub-folders which upgraded as new repositories - sql-cli - sql-odbc - sql-jdbc - dashboards-query-workbench - add additional workflow run triggers - move the BI tests to jdbc/odbc - move the sql-cli outside and clone for the doctest build Signed-off-by: YANGDB <yang.db.dev@gmail.com> * Merge remote-tracking branch 'upstream/main' Signed-off-by: YANGDB <yang.db.dev@gmail.com> * add sql-jdbc dependendcy to gradle Signed-off-by: YANGDB <yang.db.dev@gmail.com> * Disallow unquoted literals in `LIKE` clause in `DESCRIBE` statement (#1181) * Allow quoted literals only in `DESCRIBE` and `SHOW` clauses. Tests. Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com> * Fix doctest after rebase. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Fix doctest after rebase. - Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Update syntax section. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Creation and updating 2.x branch (#6) * Create the 2.x branch * Add workflow_dispatch: to github CLI Signed-off-by: YANGDB <yang.db.dev@gmail.com> * remove sub-folders which upgraded as new repositories - sql-cli - sql-odbc - sql-jdbc - dashboards-query-workbench Signed-off-by: YANG-DB <yang-db-dev@gmail.com> * add additional workflow run triggers Signed-off-by: YANGDB <yang.db.dev@gmail.com> * Merge remote-tracking branch 'upstream/main' - move the BI tests to jdbc/odbc - move the sql-cli outside and clone for the doctest build Signed-off-by: YANGDB <yang.db.dev@gmail.com> * Disallow unquoted literals in `LIKE` clause in `DESCRIBE` statement (#1181) (#3) * Allow quoted literals only in `DESCRIBE` and `SHOW` clauses. Tests. Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com> * Fix doctest after rebase. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Fix doctest after rebase. - Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Update syntax section. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: YANG-DB <yang-db-dev@gmail.com> Signed-off-by: YANGDB <yang.db.dev@gmail.com> Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: lior perry <lioperry@amazon.com> Co-authored-by: yang-db <yang-db-dev@gmail.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>

) * # This is a combination of 9 commits. # This is the 1st commit message: Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (#1899) * Added setDefaultMediaType for create_index and create_index_with_IOException Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> (cherry picked from commit 7b932a7) Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Resolving merge conflicts for pre tag in java docs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Converts java doc table to proper java doc table. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Resolving merge conflicts for pre tag in java docs 2 Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> cherry pick 60c0018 Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Addressed PR comment for table format in AbstractExprValue. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from ExpressionReferenceOptimizer. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from AstDSL.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from AstDSL.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from SelectExpressionAnalyzer.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> fixed java doc in QualifiedName.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removing checkstyle test for core and added spotless for relevant directories. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> # This is the commit message #2: Fixing spacing around headers in ExpressionReferenceOptimizer.java SelectExpressionAnalyzer.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> # This is the commit message #3: Fix breaking changes. Disable some flaky tests in legacy. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> (cherry picked from commit 809e656) Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> # This is the commit message #4: Resolving merge conflicts for pre tag in java docs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> # This is the commit message #5: running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> # This is the commit message #6: Fixed java doc spelling and improving string concatination. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> # This is the commit message #7: improving string concatination. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> # This is the commit message #8: Improving failure format on some functions. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> # This is the commit message #9: spotless apply and fix of build.gradle Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * parent 496fe8e author Mitchell Gale <Mitchell.Gale@improving.com> 1691080710 -0700 committer Mitchell Gale <Mitchell.Gale@improving.com> 1691080766 -0700 Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (#1899) * Added setDefaultMediaType for create_index and create_index_with_IOException Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> (cherry picked from commit 7b932a7) Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Resolving merge conflicts for pre tag in java docs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Converts java doc table to proper java doc table. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Resolving merge conflicts for pre tag in java docs 2 Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> cherry pick 60c0018 Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Addressed PR comment for table format in AbstractExprValue. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from ExpressionReferenceOptimizer. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from AstDSL.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from AstDSL.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from SelectExpressionAnalyzer.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> fixed java doc in QualifiedName.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removing checkstyle test for core and added spotless for relevant directories. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Fixing spacing around headers in ExpressionReferenceOptimizer.java SelectExpressionAnalyzer.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Fix breaking changes. Disable some flaky tests in legacy. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> (cherry picked from commit 809e656) Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Resolving merge conflicts for pre tag in java docs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Fixed java doc spelling and improving string concatination. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> improving string concatination. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Improving failure format on some functions. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> spotless apply and fix of build.gradle Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Resolving merge conflicts for pre tag in java docs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Converts java doc table to proper java doc table. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removing unused import in OpenSearchRestClientTest.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * running spotless apply. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Addressed comments in PR 5. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Spotless apply for datasources. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * ignore checkstyle for datasources Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

…-plan Ensuring all sub aggs are pushed down and remove reliance on doc_count

…dar162010361-pkl-pipelines (rdar://162010361) Migrate from Rio YAML config to PKL-based pipelines configuration

davidcui1225 added 2 commits April 13, 2021 16:16

migrate to opensearch

2db19a8

rename dir in readme

59dd41f

davidcui1225 requested a review from dblock April 13, 2021 23:26

update test and build workflow

4d7cc7b

dblock suggested changes Apr 14, 2021

View reviewed changes

dai-chen mentioned this pull request Apr 14, 2021

OpenSearch Migration for SQL/PPL #2

Merged

davidcui1225 added 3 commits April 16, 2021 11:35

use opensearch dashboards over kibana

3b2032b

add renaming changes

299eb14

update release workflow and tslint ES BV license statement

eb0b464

davidcui1225 requested a review from dblock April 16, 2021 19:20

dblock approved these changes Apr 17, 2021

View reviewed changes

davidcui1225 merged commit 1cc931c into develop Apr 17, 2021

joshuali925 pushed a commit to joshuali925/sql that referenced this pull request Jan 4, 2022

Merge pull request opensearch-project#6 from Bit-Quill/dialect-string…

2355abf

…s-AOS-202-CAST Dialect: Added CAST to convert to int and string as of AOS-202

alchemist51 pushed a commit to alchemist51/sql that referenced this pull request Nov 7, 2025

Merge pull request opensearch-project#6 from expani/feature/substrait…

ff3cece

…-plan Ensuring all sub aggs are pushed down and remove reliance on doc_count

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate workbench to OpenSearch Dashboards#6

Migrate workbench to OpenSearch Dashboards#6
davidcui1225 merged 6 commits intodevelopfrom
opensearch/workbench

davidcui1225 commented Apr 13, 2021

Uh oh!

Uh oh!

dblock Apr 14, 2021

Uh oh!

davidcui1225 Apr 14, 2021

Uh oh!

dblock Apr 14, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dblock Apr 14, 2021

Uh oh!

davidcui1225 Apr 14, 2021

Uh oh!

dblock Apr 14, 2021

Uh oh!

davidcui1225 Apr 14, 2021

Uh oh!

dblock Apr 14, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

davidcui1225 commented Apr 13, 2021

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants