Skip to content

[Spotless] Applying Google Code Format for datasource files #6#1939

Merged
GumpacG merged 4 commits intoopensearch-project:mainfrom
Bit-Quill:integ/sl_GoogleJavaFormat6
Aug 10, 2023
Merged

[Spotless] Applying Google Code Format for datasource files #6#1939
GumpacG merged 4 commits intoopensearch-project:mainfrom
Bit-Quill:integ/sl_GoogleJavaFormat6

Conversation

@MitchellGale
Copy link
Copy Markdown
Contributor

Description

Applies spotless for Google Java Code Format for the datasource directory.

Issues Resolved

#1101

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

MitchellGale and others added 3 commits August 3, 2023 13:20
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
[Spotless] Applying Google Code Format for datasource files #6
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 5, 2023

Codecov Report

Merging #1939 (9a3e0f6) into main (91bbb5d) will increase coverage by 0.00%.
The diff coverage is 70.34%.

@@            Coverage Diff            @@
##               main    #1939   +/-   ##
=========================================
  Coverage     97.51%   97.51%           
  Complexity     4657     4657           
=========================================
  Files           408      408           
  Lines         11931    11933    +2     
  Branches        830      829    -1     
=========================================
+ Hits          11634    11637    +3     
+ Misses          290      289    -1     
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.51% <70.34%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ources/exceptions/DataSourceNotFoundException.java 100.00% <ø> (ø)
...earch/sql/datasources/exceptions/ErrorMessage.java 0.00% <ø> (ø)
...model/transport/CreateDataSourceActionRequest.java 30.00% <0.00%> (+2.72%) ⬆️
...odel/transport/CreateDataSourceActionResponse.java 0.00% <ø> (ø)
...model/transport/DeleteDataSourceActionRequest.java 21.42% <0.00%> (+2.67%) ⬆️
...odel/transport/DeleteDataSourceActionResponse.java 0.00% <ø> (ø)
...es/model/transport/GetDataSourceActionRequest.java 30.00% <0.00%> (+2.72%) ⬆️
...s/model/transport/GetDataSourceActionResponse.java 0.00% <ø> (ø)
...model/transport/UpdateDataSourceActionRequest.java 30.00% <0.00%> (+2.72%) ⬆️
...odel/transport/UpdateDataSourceActionResponse.java 0.00% <ø> (ø)
... and 12 more

GumpacG
GumpacG previously approved these changes Aug 8, 2023
Yury-Fridlyand
Yury-Fridlyand previously approved these changes Aug 8, 2023
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
@MitchellGale MitchellGale dismissed stale reviews from Yury-Fridlyand and GumpacG via 9a3e0f6 August 10, 2023 17:59
@GumpacG GumpacG merged commit 6d39aaf into opensearch-project:main Aug 10, 2023
MitchellGale added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Aug 14, 2023
…earch-project#1939)

* Spotless apply for datasources.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* ignore checkstyle for datasources

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

---------

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Aug 22, 2023
…earch-project#1939)

* Spotless apply for datasources.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* ignore checkstyle for datasources

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

---------

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
MitchellGale added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Aug 22, 2023
…earch-project#1939)

* Spotless apply for datasources.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* ignore checkstyle for datasources

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

---------

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
MitchellGale added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Aug 22, 2023
…earch-project#1939)

* Spotless apply for datasources.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* ignore checkstyle for datasources

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

---------

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants