Fixing string format change#1943
Merged
acarbonetto merged 1 commit intoopensearch-project:mainfrom Aug 9, 2023
Merged
Conversation
* Fixing strings change from main OS repo. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Fixing issues. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Fixing changed syntax to toStirng. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Fixing changed syntax to toStirng. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * add tosttring fix to RestSQLQueryActionCursorFallbackTest Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * added unused function Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
matthewryanwells
approved these changes
Aug 8, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (97.42%) is below the target coverage (99.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1943 +/- ##
=========================================
Coverage 97.42% 97.42%
Complexity 4647 4647
=========================================
Files 408 408
Lines 11526 11526
Branches 839 839
=========================================
Hits 11229 11229
Misses 290 290
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Yury-Fridlyand
approved these changes
Aug 8, 2023
6 tasks
GumpacG
approved these changes
Aug 9, 2023
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-1943-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 88f36bd4ee38a8a6c233eb0677d664a1ebe92c88
# Push it to GitHub
git push --set-upstream origin backport/backport-1943-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.xThen, create a pull request where the |
MitchellGale
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Aug 14, 2023
* Fixing strings change from main OS repo. * Fixing issues. * Fixing changed syntax to toStirng. * Fixing changed syntax to toStirng. * add tosttring fix to RestSQLQueryActionCursorFallbackTest * added unused function --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix changes in regards to this PR opensearch-project/OpenSearch#9127 with breaking changes.
Changes imports to include new path inside core. Update calls to toString.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.