[Backport 2.x] [Refactor] CollectionUtils, Iterators, and String methods to core lib (#9120) by nknize · Pull Request #9127 · opensearch-project/OpenSearch

nknize · 2023-08-04T21:49:54Z

Backport 5bb7fa3 from #9120.

…opensearch-project#9120) This commit refactors the CollectionUtils, and Iterators utility classes to the core and common libraries, respectively. Several other base Strings utility methods are also refactored to the core Strings utility library. This is done to incrementally move the remaining Strings methods in server to the core String utility. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> (cherry picked from commit 5bb7fa3)

github-actions · 2023-08-04T21:54:41Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/21916/
CommitID: 73f9a3f
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-08-04T22:11:29Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/21920/
CommitID: d005a59
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>

opensearch-trigger-bot · 2023-08-04T22:14:45Z

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/ml-commons.git]
Components skipped due to git failures: [https://github.com/opensearch-project/opensearch-oci-object-storage.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/reporting.git]

BUILD SUCCESSFUL in 24m 23s

opensearch-trigger-bot · 2023-08-04T22:42:29Z

Compatibility status:

> Task :checkCompatibility
Checking compatibility for: https://github.com/opensearch-project/opensearch-oci-object-storage.git with ref: 2.x
Skipping compatibility check for https://github.com/opensearch-project/opensearch-oci-object-storage.git
Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git]
Components skipped due to git failures: [https://github.com/opensearch-project/opensearch-oci-object-storage.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

BUILD SUCCESSFUL in 35m 15s

opensearch-trigger-bot · 2023-08-04T22:45:43Z

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git]
Components skipped due to git failures: [https://github.com/opensearch-project/opensearch-oci-object-storage.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

BUILD SUCCESSFUL in 32m 7s

github-actions · 2023-08-04T22:58:39Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/21921/
CommitID: cacaa76

codecov · 2023-08-04T23:00:01Z

Codecov Report

Merging #9127 (cacaa76) into 2.x (b3c8a94) will increase coverage by 0.10%.
Report is 2 commits behind head on 2.x.
The diff coverage is 70.93%.

@@             Coverage Diff              @@
##                2.x    #9127      +/-   ##
============================================
+ Coverage     70.72%   70.82%   +0.10%     
- Complexity    57417    57484      +67     
============================================
  Files          4754     4754              
  Lines        271673   271688      +15     
  Branches      40070    40070              
============================================
+ Hits         192140   192426     +286     
+ Misses        63061    62769     -292     
- Partials      16472    16493      +21

Files Changed	Coverage Δ
.../java/org/opensearch/client/RequestConverters.java	`84.66% <ø> (+1.00%)`	⬆️
.../java/org/opensearch/common/collect/Iterators.java	`75.00% <ø> (ø)`
...g/opensearch/core/common/util/CollectionUtils.java	`77.06% <ø> (ø)`
...org/opensearch/geo/algorithm/PolygonGenerator.java	`93.93% <ø> (ø)`
.../org/opensearch/ingest/common/ScriptProcessor.java	`96.96% <ø> (ø)`
...script/mustache/CustomReflectionObjectHandler.java	`68.62% <ø> (ø)`
.../org/opensearch/painless/lookup/PainlessClass.java	`47.82% <ø> (ø)`
...org/opensearch/painless/lookup/PainlessLookup.java	`79.82% <ø> (ø)`
...e/lucene/search/grouping/CollapseTopFieldDocs.java	`83.33% <ø> (+1.96%)`	⬆️
...n/cluster/health/TransportClusterHealthAction.java	`43.34% <ø> (ø)`
... and 48 more

... and 474 files with indirect coverage changes

nknize added enhancement Enhancement or improvement to existing feature or request backport PRs or issues specific to backporting features or enhancments skip-changelog v2.10.0 labels Aug 4, 2023

add suppress warning

cacaa76

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>

nknize force-pushed the backport/backport-9120-to-2.x branch from d005a59 to cacaa76 Compare August 4, 2023 22:13

andrross approved these changes Aug 4, 2023

View reviewed changes

andrross merged commit e59b21a into opensearch-project:2.x Aug 4, 2023

This was referenced Aug 8, 2023

Fixing string format change Bit-Quill/opensearch-project-sql#334

Merged

Fixing string format change opensearch-project/sql#1943

Merged

[Manual Backport #1943] Fixing string format change #1943 opensearch-project/sql#1946

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Backport 2.x] [Refactor] CollectionUtils, Iterators, and String methods to core lib (#9120)#9127

[Backport 2.x] [Refactor] CollectionUtils, Iterators, and String methods to core lib (#9120)#9127
andrross merged 2 commits intoopensearch-project:2.xfrom
nknize:backport/backport-9120-to-2.x

nknize commented Aug 4, 2023

Uh oh!

github-actions bot commented Aug 4, 2023

Uh oh!

github-actions bot commented Aug 4, 2023

Uh oh!

opensearch-trigger-bot bot commented Aug 4, 2023

Uh oh!

opensearch-trigger-bot bot commented Aug 4, 2023

Uh oh!

opensearch-trigger-bot bot commented Aug 4, 2023

Uh oh!

github-actions bot commented Aug 4, 2023

Uh oh!

codecov bot commented Aug 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

nknize commented Aug 4, 2023

Uh oh!

github-actions bot commented Aug 4, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 4, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

opensearch-trigger-bot bot commented Aug 4, 2023

Uh oh!

opensearch-trigger-bot bot commented Aug 4, 2023

Uh oh!

opensearch-trigger-bot bot commented Aug 4, 2023

Uh oh!

github-actions bot commented Aug 4, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

codecov bot commented Aug 4, 2023

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants