Skip to content

Added SINH function to V2 engine#1434

Merged
dai-chen merged 1 commit intoopensearch-project:mainfrom
Bit-Quill:integ-sinh
Mar 15, 2023
Merged

Added SINH function to V2 engine#1434
dai-chen merged 1 commit intoopensearch-project:mainfrom
Bit-Quill:integ-sinh

Conversation

@matthewryanwells
Copy link
Copy Markdown
Contributor

@matthewryanwells matthewryanwells commented Mar 13, 2023

Description

Updated SINH function to V2 engine, added documentation, unit/IT tests

Issues Resolved

#1190

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@matthewryanwells
Added SINH function to V2 engine (#242)
1f76056 
* Updated SINH function to V2 engine, added documentation, unit/IT tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
@matthewryanwells matthewryanwells requested a review from a team as a code owner March 13, 2023 22:09
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Mar 14, 2023
Closed
10 tasks
@dai-chen dai-chen merged commit c9f96fb into opensearch-project:main Mar 15, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 15, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 15, 2023
@matthewryanwells @github-actions
Added SINH function to V2 engine (#242) (#1434)
ac23198 
* Updated SINH function to V2 engine, added documentation, unit/IT tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
(cherry picked from commit c9f96fb)
Yury-Fridlyand pushed a commit that referenced this pull request Mar 15, 2023
@opensearch-trigger-bot @matthewryanwells
Added SINH function to V2 engine (#242) (#1434) (#1437)
00ff7eb 
* Updated SINH function to V2 engine, added documentation, unit/IT tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
(cherry picked from commit c9f96fb)

Co-authored-by: Matthew Wells <matthew.wells@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dai-chen dai-chen dai-chen approved these changes

+2 more reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@MaxKsyunz MaxKsyunz MaxKsyunz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport 2.x enhancement New feature or request v2.7.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matthewryanwells @dai-chen @Yury-Fridlyand @MaxKsyunz