Added SINH function to V2 engine#242
Merged
matthewryanwells merged 6 commits intointeg-sinhfrom Mar 13, 2023
Merged
Conversation
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Codecov Report
@@ Coverage Diff @@
## integ-sinh #242 +/- ##
=============================================
Coverage 98.38% 98.38%
- Complexity 3695 3698 +3
=============================================
Files 343 343
Lines 9113 9118 +5
Branches 582 582
=============================================
+ Hits 8966 8971 +5
Misses 142 142
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Yury-Fridlyand
approved these changes
Mar 9, 2023
…rigometric section Signed-off-by: Matthew Wells <matthew.wells@improving.com>
GumpacG
approved these changes
Mar 9, 2023
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Pulling changes from upstream
GabeFernandez310
left a comment
There was a problem hiding this comment.
Looks fine except for 1 failure in a doctest I think?
GabeFernandez310
approved these changes
Mar 13, 2023
acarbonetto
approved these changes
Mar 13, 2023
...src/test/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunctionTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunctionTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunctionTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunctionTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
matthewryanwells
added a commit
that referenced
this pull request
Mar 15, 2023
* Updated SINH function to V2 engine, added documentation, unit/IT tests Signed-off-by: Matthew Wells <matthew.wells@improving.com>
GabeFernandez310
pushed a commit
that referenced
this pull request
Mar 16, 2023
…ensearch-project#1437) * Updated SINH function to V2 engine, added documentation, unit/IT tests Signed-off-by: Matthew Wells <matthew.wells@improving.com> (cherry picked from commit c9f96fb) Co-authored-by: Matthew Wells <matthew.wells@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added math function SINH to V2 engine, updated documentation, and added unit/IT tests
Issues Resolved
opensearch-project#1190
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.