Add tests for account-nav-button when multitenancy is disabled#1020
Merged
peternied merged 1 commit intoopensearch-project:mainfrom Jul 6, 2022
Merged
Add tests for account-nav-button when multitenancy is disabled#1020peternied merged 1 commit intoopensearch-project:mainfrom
peternied merged 1 commit intoopensearch-project:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1020 +/- ##
==========================================
+ Coverage 72.21% 72.27% +0.05%
==========================================
Files 87 87
Lines 1915 1915
Branches 249 249
==========================================
+ Hits 1383 1384 +1
Misses 478 478
+ Partials 54 53 -1
Continue to review full report at Codecov.
|
peternied
previously approved these changes
Jul 1, 2022
Member
peternied
left a comment
There was a problem hiding this comment.
Please clean up the description, while this isn't required it would make it easier to parse and understand what this change accomplishes:
GITHUB-DESCRIPTION 1020.diff
Produced: 7/1/2022 11:57:34 AM
Mode: All, Ignoring Unimportant
Left file: C:\Users\petern\Desktop\1.txt Right file: C:\Users\petern\Desktop\2.txt
SUBJECT: Add tests for account-nav-button when multitenancy is disabled #1020 = SUBJECT: Add tests for account-nav-button when multitenancy is disabled #1020
BODY: BODY:
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Signed-off-by: Craig Perkins <cwperx@amazon.com> +-
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
=
### Description ### Description
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
[Describe what this change achieves] +-
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
=
This adds a test for [#965](https://github.com/opensearch-project/security-dashboards-plugin/pull/965) which is described in this issue [975](https://github.com/opensearch-project/security-dashboards-plugin/issues/975) This adds a test for [#965](https://github.com/opensearch-project/security-dashboards-plugin/pull/965) which is described in this issue [975](https://github.com/opensearch-project/security-dashboards-plugin/issues/975)
When multitenancy is disabled in `opensearch_dashboards.yml` the user should not be prompted with the tenant modal. When multitenancy is disabled in `opensearch_dashboards.yml` the user should not be prompted with the tenant modal.
### Category ### Category
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation] <>
Test fix
### Why these changes are required?
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
=
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
### What is the old behavior before changes and new behavior after changes? +-
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
=
### Issues Resolved ### Issues Resolved
[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)] [List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
<> - Resolves #975
This resolves issue [975](https://github.com/opensearch-project/security-dashboards-plugin/issues/975).
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
=
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
### Testing +-
[Please provide details of testing done: unit testing, integration testing and manual testing]
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
=
### Check List ### Check List
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
- [ ] New functionality includes testing <> - [X] New functionality includes testing
- [ ] New functionality has been documented - [ ] ~New functionality has been documented~
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
- [X] Commits are signed per the DCO using --signoff = - [X] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
cliu123
reviewed
Jul 1, 2022
DarshitChanpura
previously approved these changes
Jul 5, 2022
cliu123
requested changes
Jul 5, 2022
Member
cliu123
left a comment
There was a problem hiding this comment.
The PR looks good to me. Please resolve the only pending comment at this moment, so we can merge it. Thanks!
Signed-off-by: Craig Perkins <cwperx@amazon.com>
c62e56e to
4b77770
Compare
cliu123
approved these changes
Jul 6, 2022
DarshitChanpura
approved these changes
Jul 6, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit 4527d1a)
peternied
pushed a commit
that referenced
this pull request
Jul 6, 2022
spartan2015
pushed a commit
to spartan2015/security-dashboards-plugin
that referenced
this pull request
Aug 8, 2022
…earch-project#1020) Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: Vasile Negru <vasile@eosfintek.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Craig Perkins cwperx@amazon.com
Description
This adds a test for #965 which is described in this issue 975
When multitenancy is disabled in
opensearch_dashboards.ymlthe user should not be prompted with the tenant modal.Category
New Tests
Issues Resolved
This resolves issue 975.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.