Fix flaky test SlowIntegrationTests.testDelayInSecurityIndexInitialization#3763
Merged
peternied merged 11 commits intoopensearch-project:mainfrom Dec 14, 2023
Merged
Fix flaky test SlowIntegrationTests.testDelayInSecurityIndexInitialization#3763peternied merged 11 commits intoopensearch-project:mainfrom
peternied merged 11 commits intoopensearch-project:mainfrom
Conversation
…ation Signed-off-by: Craig Perkins <cwperx@amazon.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3763 +/- ##
==========================================
- Coverage 65.27% 65.25% -0.03%
==========================================
Files 298 298
Lines 21159 21159
Branches 3455 3455
==========================================
- Hits 13812 13807 -5
- Misses 5653 5656 +3
- Partials 1694 1696 +2 |
2 tasks
Member
DarshitChanpura
left a comment
There was a problem hiding this comment.
ty @cwperks! This will resolve a big CI blocker.
Can we confirm the fix by running across multiple CI runs?
3 tasks
Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks
commented
Dec 5, 2023
src/test/java/org/opensearch/security/SlowIntegrationTests.java
Outdated
Show resolved
Hide resolved
Member
Author
|
FYI @DarshitChanpura this passed the 10x check. I will remove the line to repeat the test. |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks
commented
Dec 7, 2023
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Member
Author
|
@peternied @DarshitChanpura This PR adds back in the SlowIntegrationTests.testDelayInSecurityIndexInitialization that was removed in #3706, but updates the test to make it stable. IMO I would like to keep the test in, but have it been a reliable test. |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
peternied
reviewed
Dec 12, 2023
peternied
reviewed
Dec 12, 2023
src/test/java/org/opensearch/security/SlowIntegrationTests.java
Outdated
Show resolved
Hide resolved
peternied
reviewed
Dec 12, 2023
src/test/java/org/opensearch/security/SlowIntegrationTests.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/security/SlowIntegrationTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Member
Author
|
@peternied Can I get another review of this? All comments have been addressed. This will re-instate a (flaky) test that was recently removed, but stabilizes the test. |
peternied
approved these changes
Dec 14, 2023
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-3763-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7498eb00679c307b75db80f54476a01ace48fae9
# Push it to GitHub
git push --set-upstream origin backport/backport-3763-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.xThen, create a pull request where the |
Member
Author
|
I will create a manual backport |
cwperks
added a commit
to cwperks/security
that referenced
this pull request
Dec 14, 2023
…ation (opensearch-project#3763) Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit 7498eb0)
dlin2028
pushed a commit
to dlin2028/security
that referenced
this pull request
May 1, 2024
…ation (opensearch-project#3763) Signed-off-by: Craig Perkins <cwperx@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Explicitly adds a command after setup to create an index and wait for cluster green which produces the expected IOException.
The pseudo code of this test is:
I believe this test is not succeeding, because the cluster is coming up as green initially since there is no data (and hence no shards) in the cluster. By adding an explicit command to create an index, the test ensures that the shards are not being allocated and cluster is indeed red.
Test Fix
Issues Resolved
SlowIntegrationTests.testDelayInSecurityIndexInitialization#2230Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.