Skip to content

Enable windows platform for integration tests cases#3706

Merged
peternied merged 6 commits intoopensearch-project:mainfrom
MaciejMierzwa:integration-tests-windows
Dec 8, 2023
Merged

Enable windows platform for integration tests cases#3706
peternied merged 6 commits intoopensearch-project:mainfrom
MaciejMierzwa:integration-tests-windows

Conversation

@MaciejMierzwa
Copy link
Copy Markdown
Contributor

@MaciejMierzwa MaciejMierzwa commented Nov 14, 2023

Description

  • Category Test fix

Issues Resolved

Is this a backport? If so, please add backport PR # and/or commits #

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 14, 2023

Codecov Report

Merging #3706 (ce05c45) into main (5114bb7) will decrease coverage by 0.04%.
Report is 7 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3706      +/-   ##
==========================================
- Coverage   65.24%   65.20%   -0.04%     
==========================================
  Files         297      297              
  Lines       21129    21132       +3     
  Branches     3451     3452       +1     
==========================================
- Hits        13786    13780       -6     
- Misses       5643     5655      +12     
+ Partials     1700     1697       -3     
Files Coverage Δ
...earch/security/resolver/IndexResolverReplacer.java 69.35% <100.00%> (+0.24%) ⬆️

... and 2 files with indirect coverage changes

@peternied
Copy link
Copy Markdown
Member

@MaciejMierzwa Please look into the following failures and link/create issues for these flaky tests

  • CI / test (citest, ubuntu-latest, 11) (pull_request)
  • CI / test (citest, windows-latest, 17) (pull_request)

@peternied peternied changed the title add windows-latest to integration-tests ci Enable windows platform for integration tests cases Nov 21, 2023
Copy link
Copy Markdown
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request is attempting to merge into the 2.x branch, please change this PR to target main.

@MaciejMierzwa MaciejMierzwa changed the base branch from 2.x to main November 23, 2023 16:42
Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
Copy link
Copy Markdown
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty for this contribution @MaciejMierzwa !

testDelayInSecurityIndexInitialization will be addressed in #3763

@peternied peternied merged commit 93cf507 into opensearch-project:main Dec 8, 2023
@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-3706-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 93cf507cceca6989444c6b9a047538aa42fb5bf3
# Push it to GitHub
git push --set-upstream origin backport/backport-3706-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-3706-to-2.x.

dlin2028 pushed a commit to dlin2028/security that referenced this pull request May 1, 2024
…ct#3706)

Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
DarshitChanpura pushed a commit to DarshitChanpura/security that referenced this pull request Jul 30, 2024
…ct#3706)

Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
(cherry picked from commit 93cf507)
DarshitChanpura pushed a commit to DarshitChanpura/security that referenced this pull request Jul 31, 2024
…ct#3706)

Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
(cherry picked from commit 93cf507)
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tests] integration-tests are not being run on windows

3 participants