Skip to content

Adding index template permissions to kibana_server role#2503

Merged
stephen-crawford merged 1 commit intoopensearch-project:mainfrom
cliu123:add_index_template_put_permission_to_kibanaserver_role
Mar 6, 2023
Merged

Adding index template permissions to kibana_server role#2503
stephen-crawford merged 1 commit intoopensearch-project:mainfrom
cliu123:add_index_template_put_permission_to_kibanaserver_role

Conversation

@cliu123
Copy link
Copy Markdown
Member

@cliu123 cliu123 commented Mar 4, 2023 •
edited
Loading

Description

[Describe what this change achieves]

Issues Resolved

opensearch-project/security-dashboards-plugin#1222

Is this a backport? If so, please add backport PR # and/or commits #
No

Testing

MT

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cliu123
add index template put permission to kibana_server role
e5b0244 
Signed-off-by: Chang Liu <lc12251109@gmail.com>
@cliu123 cliu123 changed the title add index template put permission to kibana_server role add index template permissions to kibana_server role Mar 4, 2023
@cliu123 cliu123 mentioned this pull request Mar 4, 2023
Merged
1 task
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 4, 2023

Codecov Report

Merging #2503 (e5b0244) into main (08e21dd) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #2503      +/-   ##
============================================
- Coverage     61.20%   61.20%   -0.01%     
+ Complexity     3326     3324       -2     
============================================
  Files           260      260              
  Lines         18497    18499       +2     
  Branches       3268     3268              
============================================
  Hits          11322    11322              
  Misses         5578     5578              
- Partials       1597     1599       +2
Impacted Files Coverage Δ
...ic/auth/http/jwt/AbstractHTTPJwtAuthenticator.java 55.29% <100.00%> (+0.53%) ⬆️
...azon/dlic/auth/http/jwt/keybyoidc/JwtVerifier.java 86.04% <100.00%> (+0.33%) ⬆️
...search/security/transport/SecurityInterceptor.java 75.38% <0.00%> (-0.77%) ⬇️
...ensearch/security/compliance/ComplianceConfig.java 82.63% <0.00%> (-0.70%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cliu123 cliu123 changed the title add index template permissions to kibana_server role Adding index template permissions to kibana_server role Mar 4, 2023
@cliu123 cliu123 requested a review from a team March 4, 2023 08:08
@cliu123 cliu123 added backport 2.x backport 2.1 backport 2.2 backport to 2.2 backport 2.3 backport to 2.3 branch backport 2.4 backport 2.5 backport to 2.5 branch backport 1.x backport to 1.x branch backport 1.2 backport to 1.2 branch backport 1.3 backport to 1.3 branch backport 1.1 backport to 1.1 branch backport 1.0 backport to 1.0 branch backport opendistro-1.13 Backport to opendistro-1.13 branch backport opendistro-1.11 Backport to opendistro-1.11 branch backport 2.0 backport to 2.0 branch backport 2.6 backport to 2.6 branch labels Mar 6, 2023
@stephen-crawford stephen-crawford removed the backport 1.2 backport to 1.2 branch label Mar 6, 2023
@cliu123 cliu123 added backport 2.5 backport to 2.5 branch backport opendistro-1.11 Backport to opendistro-1.11 branch labels Mar 6, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 6, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 6, 2023
@cliu123 @github-actions
add index template put permission to kibana_server role (#2503)
1f0a74b 
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit fb70a75)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 6, 2023
@cliu123 @github-actions
add index template put permission to kibana_server role (#2503)
bbffd1e 
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit fb70a75)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 6, 2023
@cliu123 @github-actions
add index template put permission to kibana_server role (#2503)
e912a1a 
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit fb70a75)
This was referenced Mar 6, 2023
Merged
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 6, 2023
@cliu123 @github-actions
add index template put permission to kibana_server role (#2503)
7d78d7c 
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit fb70a75)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 6, 2023
@cliu123 @github-actions
add index template put permission to kibana_server role (#2503)
76e7178 
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit fb70a75)
This was referenced Mar 6, 2023
Merged
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 6, 2023
@cliu123 @github-actions
add index template put permission to kibana_server role (#2503)
934de42 
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit fb70a75)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 6, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 6, 2023
@cliu123 @github-actions
add index template put permission to kibana_server role (#2503)
2626e3c 
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit fb70a75)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 6, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 6, 2023
@cliu123 @github-actions
add index template put permission to kibana_server role (#2503)
6c92c17 
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit fb70a75)
This was referenced Mar 6, 2023
Merged
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 6, 2023
@cliu123 @github-actions
add index template put permission to kibana_server role (#2503)
60f4f7d 
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit fb70a75)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 6, 2023
@cliu123 @github-actions
add index template put permission to kibana_server role (#2503)
99c68e5 
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit fb70a75)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 6, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 6, 2023
@cliu123 @github-actions
add index template put permission to kibana_server role (#2503)
a9597cc 
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit fb70a75)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 6, 2023
Merged
cliu123 added a commit that referenced this pull request Mar 6, 2023
@opensearch-trigger-bot @cliu123
add index template put permission to kibana_server role (#2503) (#2506)
826a8e0 
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit fb70a75)

Co-authored-by: Chang Liu <lc12251109@gmail.com>
cliu123 added a commit that referenced this pull request Mar 6, 2023
@opensearch-trigger-bot @cliu123
add index template put permission to kibana_server role (#2503) (#2507)
c266552 
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit fb70a75)

Co-authored-by: Chang Liu <lc12251109@gmail.com>
cliu123 added a commit that referenced this pull request Mar 6, 2023
@opensearch-trigger-bot @cliu123
add index template put permission to kibana_server role (#2503) (#2509)
4d6ca7c 
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit fb70a75)

Co-authored-by: Chang Liu <lc12251109@gmail.com>
cliu123 added a commit that referenced this pull request Mar 6, 2023
@opensearch-trigger-bot @cliu123
add index template put permission to kibana_server role (#2503) (#2511)
fd339dd 
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit fb70a75)

Co-authored-by: Chang Liu <lc12251109@gmail.com>
cliu123 added a commit that referenced this pull request Mar 6, 2023
@opensearch-trigger-bot @cliu123
add index template put permission to kibana_server role (#2503) (#2516)
f656cde 
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit fb70a75)

Co-authored-by: Chang Liu <lc12251109@gmail.com>
cliu123 added a commit that referenced this pull request Mar 6, 2023
@opensearch-trigger-bot @cliu123
add index template put permission to kibana_server role (#2503) (#2515)
84d18b4 
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit fb70a75)

Co-authored-by: Chang Liu <lc12251109@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cwperks cwperks cwperks approved these changes

@DarshitChanpura DarshitChanpura Awaiting requested review from DarshitChanpura DarshitChanpura is a code owner

@davidlago davidlago Awaiting requested review from davidlago

@peternied peternied Awaiting requested review from peternied

@RyanL1997 RyanL1997 Awaiting requested review from RyanL1997 RyanL1997 is a code owner

+1 more reviewer

@stephen-crawford stephen-crawford stephen-crawford approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport opendistro-1.11 Backport to opendistro-1.11 branch backport opendistro-1.13 Backport to opendistro-1.13 branch backport 1.x backport to 1.x branch backport 1.0 backport to 1.0 branch backport 1.1 backport to 1.1 branch backport 1.2 backport to 1.2 branch backport 1.3 backport to 1.3 branch backport 2.0 backport to 2.0 branch backport 2.1 backport 2.2 backport to 2.2 backport 2.3 backport to 2.3 branch backport 2.4 backport 2.5 backport to 2.5 branch backport 2.6 backport to 2.6 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cliu123 @codecov-commenter @cwperks @stephen-crawford