Skip to content

[Backport 2.5] Adding index template permissions to kibana_server role#2509

Merged
cliu123 merged 1 commit into2.5from
backport/backport-2503-to-2.5
Mar 6, 2023
Merged

[Backport 2.5] Adding index template permissions to kibana_server role#2509
cliu123 merged 1 commit into2.5from
backport/backport-2503-to-2.5

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Mar 6, 2023

Backport fb70a75 from #2503

@cliu123 @github-actions
add index template put permission to kibana_server role (#2503)
bbffd1e 
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit fb70a75)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team March 6, 2023 17:27
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 6, 2023 •
edited
Loading

Codecov Report

Merging #2509 (bbffd1e) into 2.5 (06f767b) will increase coverage by 0.03%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.5    #2509      +/-   ##
============================================
+ Coverage     61.06%   61.09%   +0.03%     
- Complexity     3252     3255       +3     
============================================
  Files           258      258              
  Lines         18137    18137              
  Branches       3232     3232              
============================================
+ Hits          11075    11081       +6     
+ Misses         5490     5486       -4     
+ Partials       1572     1570       -2
Impacted Files Coverage Δ
...a/org/opensearch/security/tools/SecurityAdmin.java 36.00% <0.00%> (+0.24%) ⬆️
...security/auditlog/sink/ExternalOpenSearchSink.java 61.72% <0.00%> (+2.46%) ⬆️
...ch/security/auditlog/routing/AsyncStoragePool.java 55.55% <0.00%> (+5.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cliu123
Copy link
Copy Markdown
Member

cliu123 commented Mar 6, 2023

merging the backport as the Spotless scan failures are not related to this change. I re-ran, but still failed.

* What went wrong:
Execution failed for task ':spotlessJavaCheck'.
> The following files had format violations:
      src/test/java/org/opensearch/security/auth/InternalAuthBackendTests.java
          @@ -22,7 +22,6 @@
           import·org.mockito.Mockito;
           
           import·org.opensearch.OpenSearchSecurityException;
          -
           import·org.opensearch.security.auth.internal.InternalAuthenticationBackend;
           import·org.opensearch.security.securityconf.InternalUsersModel;
           import·org.opensearch.security.user.AuthCredentials;

@cliu123 cliu123 merged commit 4d6ca7c into 2.5 Mar 6, 2023
@cliu123 cliu123 deleted the backport/backport-2503-to-2.5 branch March 6, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cliu123 cliu123 cliu123 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@codecov-commenter @cliu123